[PATCH] myri10ge: Prefer unsigned int to bare use of unsigned

[PATCH] myri10ge: Prefer unsigned int to bare use of unsigned

[hanyu001]

This patch fixes the checkpatch.pl warning:

./drivers/net/ethernet/myricom/myri10ge/myri10ge.c:629: WARNING: Prefer 
'unsigned int' to bare use of 'unsigned'

Signed-off-by: maqimei <2433033762@qq.com>
---
  drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c 
b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index 8de2e5e..71b5f4c 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -626,7 +626,7 @@ static int myri10ge_load_hotplug_firmware(struct 
myri10ge_priv *mgp, u32 * size)
      vfree(fw_readback);
      if (crc != reread_crc) {
          dev_err(dev, "CRC failed(fw-len=%u), got 0x%x (expect 0x%x)\n",
-            (unsigned)fw->size, reread_crc, crc);
+            (unsigned int)fw->size, reread_crc, crc);
          status = -EIO;
          goto abort_with_fw;
      }

Re: [PATCH] myri10ge: Prefer unsigned int to bare use of unsigned

[Leon Romanovsky]

On Mon, Jul 17, 2023 at 10:39:41AM +0800, hanyu001@208suo.com wrote:
> This patch fixes the checkpatch.pl warning:
> 
> ./drivers/net/ethernet/myricom/myri10ge/myri10ge.c:629: WARNING: Prefer
> 'unsigned int' to bare use of 'unsigned'
> 
> Signed-off-by: maqimei <2433033762@qq.com>
> ---
>  drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the patch, but unfortunately netdev doesn't take pure cleanup
patches.

Thanks

[PATCH] myri10ge: Prefer unsigned int to bare use of unsigned

[hanyu001]

Fix checkpatch warnings:

./drivers/net/ethernet/myricom/myri10ge/myri10ge.c:572: WARNING: Prefer 
'unsigned int' to bare use of 'unsigned'
./drivers/net/ethernet/myricom/myri10ge/myri10ge.c:579: WARNING: Prefer 
'unsigned int' to bare use of 'unsigned'
./drivers/net/ethernet/myricom/myri10ge/myri10ge.c:614: WARNING: Prefer 
'unsigned int' to bare use of 'unsigned'

Signed-off-by: maqimei <2433033762@qq.com>
---
  drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c 
b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index 65d7057..8de2e5e 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -569,14 +569,14 @@ static void myri10ge_dummy_rdma(struct 
myri10ge_priv *mgp, int enable)

  static int myri10ge_load_hotplug_firmware(struct myri10ge_priv *mgp, 
u32 * size)
  {
-    unsigned crc, reread_crc;
+    unsigned int crc, reread_crc;
      const struct firmware *fw;
      struct device *dev = &mgp->pdev->dev;
      unsigned char *fw_readback;
      struct mcp_gen_header *hdr;
      size_t hdr_offset;
      int status;
-    unsigned i;
+    unsigned int i;

      if (request_firmware(&fw, mgp->fw_name, dev) < 0) {
          dev_err(dev, "Unable to load %s firmware image via hotplug\n",
@@ -611,7 +611,7 @@ static int myri10ge_load_hotplug_firmware(struct 
myri10ge_priv *mgp, u32 * size)
      for (i = 0; i < fw->size; i += 256) {
          myri10ge_pio_copy(mgp->sram + MYRI10GE_FW_OFFSET + i,
                    fw->data + i,
-                  min(256U, (unsigned)(fw->size - i)));
+                  min(256U, (unsigned int)(fw->size - i)));
          mb();
          readb(mgp->sram);
      }