* [PATCH] 3c59x: Add space around '='
[not found] <tencent_7B6F5BD00E87F90524CC452645A9D0DB2007@qq.com>
@ 2023-07-17 3:27 ` hanyu001
2023-07-18 17:42 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: hanyu001 @ 2023-07-17 3:27 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni; +Cc: netdev, linux-kernel
Fix checkpatch warnings:
./drivers/net/ethernet/3com/3c59x.c:716: ERROR: spaces required around
that '=' (ctx:VxV)
./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around
that '=' (ctx:VxV)
./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around
that '=' (ctx:VxV)
./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around
that '=' (ctx:VxV)
./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around
that '=' (ctx:VxV)
Signed-off-by: maqimei <2433033762@qq.com>
---
drivers/net/ethernet/3com/3c59x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/3com/3c59x.c
b/drivers/net/ethernet/3com/3c59x.c
index 082388b..9aa3244 100644
--- a/drivers/net/ethernet/3com/3c59x.c
+++ b/drivers/net/ethernet/3com/3c59x.c
@@ -713,8 +713,8 @@ static void window_set(struct vortex_private *vp,
int window)
Note that we deviate from the 3Com order by checking 10base2 before
AUI.
*/
enum xcvr_types {
- XCVR_10baseT=0, XCVR_AUI, XCVR_10baseTOnly, XCVR_10base2,
XCVR_100baseTx,
- XCVR_100baseFx, XCVR_MII=6, XCVR_NWAY=8, XCVR_ExtMII=9,
XCVR_Default=10,
+ XCVR_10baseT = 0, XCVR_AUI, XCVR_10baseTOnly, XCVR_10base2,
XCVR_100baseTx,
+ XCVR_100baseFx, XCVR_MII = 6, XCVR_NWAY = 8, XCVR_ExtMII = 9,
XCVR_Default = 10,
};
static const struct media_table {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] 3c59x: Add space around '='
2023-07-17 3:27 ` [PATCH] 3c59x: Add space around '=' hanyu001
@ 2023-07-18 17:42 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2023-07-18 17:42 UTC (permalink / raw)
To: hanyu001; +Cc: davem, edumazet, pabeni, netdev, linux-kernel
On Mon, 17 Jul 2023 11:27:10 +0800 hanyu001@208suo.com wrote:
> Fix checkpatch warnings:
>
> ./drivers/net/ethernet/3com/3c59x.c:716: ERROR: spaces required around
> that '=' (ctx:VxV)
> ./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around
> that '=' (ctx:VxV)
> ./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around
> that '=' (ctx:VxV)
> ./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around
> that '=' (ctx:VxV)
> ./drivers/net/ethernet/3com/3c59x.c:717: ERROR: spaces required around
> that '=' (ctx:VxV)
Networking does not accept checkpatch-based coding style fixes as others
already pointed out. Plus your patches are broken (white space damaged),
and you sent 10 of them before waiting for any feedback, please stop.
--
pw-bot: reject
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-18 17:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tencent_7B6F5BD00E87F90524CC452645A9D0DB2007@qq.com>
2023-07-17 3:27 ` [PATCH] 3c59x: Add space around '=' hanyu001
2023-07-18 17:42 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).