From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCA0A23BC for ; Tue, 18 Jul 2023 10:54:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4846C433C8; Tue, 18 Jul 2023 10:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689677690; bh=VkiCUBmbXEThupNefKNKWnl4TsWI33/Zru4NwUp15sY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CtZB0+of8mIHWCMLv1juOhUqqkkafip9RBlX56sG9o8x83U9k4B8NL7jjbCc8f37A bclxrPhMiDUTGSA6PYHOz2JgJViQzykXsNi5fdS1BJFIQzKQoWUMGJDGcfHQY8JGQN WIsRrRo25w2av3YKQDrwbN2wCtK9dvr3DcLCSoCG/rLSGRWsTbcsoTjYa/QNsWADZA Im3kgKg5FtTdGwjLd5Yr/sS9LK5jJj646LRMmBCubkSvNp9keJf2kK8Z/63emxCiJE WwUqS69seNytGmyGtazPuODnQM0dzYF5X4IuwmSbRlDQbD1dVJrvfALmMPVvQxzrF6 DOKzH5hcVwZPA== Date: Tue, 18 Jul 2023 13:54:46 +0300 From: Leon Romanovsky To: Ilia Lin Cc: Ilia Lin , netdev@vger.kernel.org, open list Subject: Re: [PATCH] xfrm: Allow ESP over UDP in packet offload mode Message-ID: <20230718105446.GD8808@unreal> References: <20230718092405.4124345-1-quic_ilial@quicinc.com> <20230718095242.GC8808@unreal> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Jul 18, 2023 at 01:15:12PM +0300, Ilia Lin wrote: > Hi Leon, Please don't top-post your replies. > > Indeed the policy check is checking the sec_path lags set after > decapsulation, but this has nothing to do with UDP encapsulation, the > driver will set them anyway. It doesn't make commit message correct. "In packet offload mode, the RX is bypassing the XFRM, so we can enable the encapsulation." > Regarding the driver support, each driver may restrict NAT-T support > in their state_add callback, so in common code it may stay allowed. We don't support out-of-tree drivers. Please submit it together with relevant driver changes which exercise your newly opened path. If you want, you can even take my series and submit it. Thanks > > Thanks, > Ilia > > BR, > Ilia Lin > > > > On Tue, Jul 18, 2023 at 12:53 PM Leon Romanovsky wrote: > > > > On Tue, Jul 18, 2023 at 12:24:05PM +0300, Ilia Lin wrote: > > > The ESP encapsulation is not supported only in crypto mode. > > > In packet offload mode, the RX is bypassing the XFRM, > > > so we can enable the encapsulation. > > > > It is not accurate. RX is bypassed after XFRM validated packet to ensure > > that it was really handled by HW. > > > > However, this patch should come with relevant driver code which should > > support ESP over UDP. You can see it here: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=xfrm-next > > xfrm: Support UDP encapsulation in packet offload mode > > net/mlx5e: Support IPsec NAT-T functionality > > net/mlx5e: Check for IPsec NAT-T support > > net/mlx5: Add relevant capabilities bits to support NAT-T > > > > Thanks > > > > > > > > Signed-off-by: Ilia Lin > > > --- > > > net/xfrm/xfrm_device.c | 7 ++++--- > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > > diff --git a/net/xfrm/xfrm_device.c b/net/xfrm/xfrm_device.c > > > index 4aff76c6f12e0..3018468d97662 100644 > > > --- a/net/xfrm/xfrm_device.c > > > +++ b/net/xfrm/xfrm_device.c > > > @@ -246,8 +246,10 @@ int xfrm_dev_state_add(struct net *net, struct xfrm_state *x, > > > return -EINVAL; > > > } > > > > > > - /* We don't yet support UDP encapsulation and TFC padding. */ > > > - if (x->encap || x->tfcpad) { > > > + is_packet_offload = xuo->flags & XFRM_OFFLOAD_PACKET; > > > + > > > + /* We don't yet support UDP encapsulation except full mode and TFC padding. */ > > > + if ((!is_packet_offload && x->encap) || x->tfcpad) { > > > NL_SET_ERR_MSG(extack, "Encapsulation and TFC padding can't be offloaded"); > > > return -EINVAL; > > > } > > > @@ -258,7 +260,6 @@ int xfrm_dev_state_add(struct net *net, struct xfrm_state *x, > > > return -EINVAL; > > > } > > > > > > - is_packet_offload = xuo->flags & XFRM_OFFLOAD_PACKET; > > > dev = dev_get_by_index(net, xuo->ifindex); > > > if (!dev) { > > > if (!(xuo->flags & XFRM_OFFLOAD_INBOUND)) { > > > -- > > > > > > >