From: Greg KH <gregkh@linuxfoundation.org>
To: Ross Maynard <bids.7405@bigpond.com>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, kuba@kernel.org,
Oliver Neukum <oneukum@suse.com>
Subject: Re: [PATCH] USB: zaurus: 3 broken Zaurus devices
Date: Tue, 18 Jul 2023 15:27:45 +0200 [thread overview]
Message-ID: <2023071811-dandy-jugular-b306@gregkh> (raw)
In-Reply-To: <4963f4df-e36d-94e2-a045-48469ab2a892@bigpond.com>
On Tue, Jul 18, 2023 at 10:16:55AM +1000, Ross Maynard wrote:
> Hi Greg,
>
> This is related to Oliver Neukum's patch
> 6605cc67ca18b9d583eb96e18a20f5f4e726103c (USB: zaurus: support another
> broken Zaurus) which you committed in 2022 to fix broken support for the
> Zaurus SL-6000.
>
> Prior to that I had been able to track down the original offending patch
> using git bisect as you had suggested to me:
> 16adf5d07987d93675945f3cecf0e33706566005 (usbnet: Remove over-broad module
> alias from zaurus).
>
> It turns out that the offending patch also broke support for 3 other Zaurus
> models: A300, C700 and B500/SL-5600. My patch adds the 3 device IDs to the
> driver in the same way Oliver added the SL-6000 ID in his patch.
>
> Could you please review the attached patch? I tested it on all 3 devices and
> it fixed the problem. For your reference, the associated bug URL is
> https://bugzilla.kernel.org/show_bug.cgi?id=217632.
I'll be glad to accept it if you resend it in a format that I can apply
it in. I'll run my patch-bot on it to give you some hints on what needs
to be done here.
thanks,
greg k-h
next prev parent reply other threads:[~2023-07-18 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 0:16 [PATCH] USB: zaurus: 3 broken Zaurus devices Ross Maynard
2023-07-18 13:27 ` Greg KH [this message]
2023-07-18 13:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023071811-dandy-jugular-b306@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bids.7405@bigpond.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).