netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Marek Behún" <kabel@kernel.org>
To: Stefan Eichenberger <eichest@gmail.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, hkallweit1@gmail.com,
	linux@armlinux.org.uk, francesco.dolcini@toradex.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com
Subject: Re: [PATCH net-next v3 5/5] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2110 PHY
Date: Tue, 18 Jul 2023 12:48:46 +0200	[thread overview]
Message-ID: <20230718124846.321ca18f@dellmb> (raw)
In-Reply-To: <20230717193350.285003-6-eichest@gmail.com>

On Mon, 17 Jul 2023 21:33:50 +0200
Stefan Eichenberger <eichest@gmail.com> wrote:

> +#define MARVELL_PHY_ID_88Q2110	0x002b0981

Why not put the PHY ID macro to include/linux/marvell_phy.h where all
Marvell PHY IDs reside?

Marek

      parent reply	other threads:[~2023-07-18 10:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 19:33 [PATCH net-next v3 0/5] Add a driver for the Marvell 88Q2110 PHY Stefan Eichenberger
2023-07-17 19:33 ` [PATCH net-next v3 1/5] net: phy: add registers to support 1000BASE-T1 Stefan Eichenberger
2023-07-17 21:44   ` Andrew Lunn
2023-07-17 19:33 ` [PATCH net-next v3 2/5] net: phy: c45: add support for 1000BASE-T1 forced setup Stefan Eichenberger
2023-07-17 21:44   ` Andrew Lunn
2023-07-17 19:33 ` [PATCH net-next v3 3/5] net: phy: c45: add a separate function to read BASE-T1 abilities Stefan Eichenberger
2023-07-17 21:45   ` Andrew Lunn
2023-07-17 19:33 ` [PATCH net-next v3 4/5] net: phy: c45: detect the BASE-T1 speed from the ability register Stefan Eichenberger
2023-07-17 21:45   ` Andrew Lunn
2023-07-17 19:33 ` [PATCH net-next v3 5/5] net: phy: marvell-88q2xxx: add driver for the Marvell 88Q2110 PHY Stefan Eichenberger
2023-07-17 21:54   ` Andrew Lunn
2023-07-18  7:16     ` Stefan Eichenberger
2023-07-18 13:00       ` Andrew Lunn
2023-07-18 10:48   ` Marek Behún [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230718124846.321ca18f@dellmb \
    --to=kabel@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eichest@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).