From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: "David Ahern" <dsahern@kernel.org>,
"Maciej Żenczykowski" <maze@google.com>,
"Linux Network Development Mailing List" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net] ipv6 addrconf: fix bug where deleting a mngtmpaddr can create a new temporary address
Date: Tue, 18 Jul 2023 16:08:32 -0700 [thread overview]
Message-ID: <20230718160832.0caea152@kernel.org> (raw)
In-Reply-To: <7f295784-b833-479a-daf4-84e4f89ec694@kernel.org>
On Fri, 14 Jul 2023 08:49:55 -0600 David Ahern wrote:
> > I did consider that and I couldn't quite convince myself that simply
> > removing "|| list_empty()" from the if statement is necessarily correct
> > (thus I went with the more obviously correct change).
> >
> > Are you convinced dropping the || list_empty would work?
> > I assume it's there for some reason...
>
> I am hoping Jiri can recall why that part was added since it has the
> side effect of adding an address on a delete which should not happen.
Did we get stuck here? Jiri are you around to answer?
next prev parent reply other threads:[~2023-07-18 23:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 13:55 [PATCH net] ipv6 addrconf: fix bug where deleting a mngtmpaddr can create a new temporary address Maciej Żenczykowski
2023-07-12 13:58 ` Maciej Żenczykowski
2023-07-13 14:59 ` David Ahern
2023-07-13 15:03 ` Maciej Żenczykowski
2023-07-14 14:49 ` David Ahern
2023-07-18 23:08 ` Jakub Kicinski [this message]
2023-07-18 23:18 ` David Ahern
2023-07-19 6:47 ` Jiri Pirko
2023-07-19 12:50 ` Maciej Żenczykowski
2023-07-20 15:35 ` David Ahern
2023-07-20 16:00 ` [PATCH net v2] " Maciej Żenczykowski
2023-07-20 16:34 ` Jakub Kicinski
2023-07-20 16:52 ` Maciej Żenczykowski
2023-07-24 12:07 ` Maciej Żenczykowski
2023-07-24 18:09 ` Jakub Kicinski
2023-07-24 18:20 ` Maciej Żenczykowski
2023-07-24 18:26 ` David Ahern
2023-07-24 23:00 ` patchwork-bot+netdevbpf
2023-07-25 4:59 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718160832.0caea152@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=jiri@resnulli.us \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).