From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: ast@kernel.org, andrii@kernel.org, martin.lau@linux.dev,
razor@blackwall.org, sdf@google.com, john.fastabend@gmail.com,
dxu@dxuuu.xyz, joe@cilium.io, toke@kernel.org,
davem@davemloft.net, bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v5 2/8] bpf: Add fd-based tcx multi-prog infra with link support
Date: Tue, 18 Jul 2023 17:25:31 -0700 [thread overview]
Message-ID: <20230718172531.67b639fc@kernel.org> (raw)
In-Reply-To: <20230714141545.26904-3-daniel@iogearbox.net>
On Fri, 14 Jul 2023 16:15:39 +0200 Daniel Borkmann wrote:
> +void tcx_inc(void)
> +{
> + static_branch_inc(&tcx_needed_key);
> +}
> +EXPORT_SYMBOL_GPL(tcx_inc);
> +
> +void tcx_dec(void)
> +{
> + static_branch_dec(&tcx_needed_key);
> +}
> +EXPORT_SYMBOL_GPL(tcx_dec);
Do these need to be exported? Otherwise:
Acked-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2023-07-19 0:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 14:15 [PATCH bpf-next v5 0/8] BPF link support for tc BPF programs Daniel Borkmann
2023-07-14 14:15 ` [PATCH bpf-next v5 1/8] bpf: Add generic attach/detach/query API for multi-progs Daniel Borkmann
2023-07-17 17:14 ` Stanislav Fomichev
2023-07-19 14:22 ` Daniel Borkmann
2023-07-14 14:15 ` [PATCH bpf-next v5 2/8] bpf: Add fd-based tcx multi-prog infra with link support Daniel Borkmann
2023-07-19 0:25 ` Jakub Kicinski [this message]
2023-07-19 14:15 ` Daniel Borkmann
2023-07-14 14:15 ` [PATCH bpf-next v5 3/8] libbpf: Add opts-based attach/detach/query API for tcx Daniel Borkmann
2023-07-14 14:15 ` [PATCH bpf-next v5 4/8] libbpf: Add link-based " Daniel Borkmann
2023-07-14 14:15 ` [PATCH bpf-next v5 5/8] libbpf: Add helper macro to clear opts structs Daniel Borkmann
2023-07-14 14:15 ` [PATCH bpf-next v5 6/8] bpftool: Extend net dump with tcx progs Daniel Borkmann
2023-07-14 14:15 ` [PATCH bpf-next v5 7/8] selftests/bpf: Add mprog API tests for BPF tcx opts Daniel Borkmann
2023-07-14 14:15 ` [PATCH bpf-next v5 8/8] selftests/bpf: Add mprog API tests for BPF tcx links Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718172531.67b639fc@kernel.org \
--to=kuba@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dxu@dxuuu.xyz \
--cc=joe@cilium.io \
--cc=john.fastabend@gmail.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=sdf@google.com \
--cc=toke@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).