From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A61617D5 for ; Wed, 19 Jul 2023 03:19:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9407CC433C8; Wed, 19 Jul 2023 03:19:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689736754; bh=GnR07wMqsrVaA89GG4qIhsc+HR+D0gk1Mbi/tqe3bjU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=o9y4vXhc1UTU+hHFxOKLE8EWBnUHKnF4Xzyl3vZ/ftCTcj3l10qLchIMnw8ROyc2m KTYWibIlvcv5Ca2skgd21omxCA/vSzKXdxd3z/bxPi1J7BXA7IOCKm8P7oU8P90YLI UjrH2/y673jGoW7/VS2mwy7Q1EgfQcPeZt4pxM8cDf+IWLVMHjj7Vlaf+jK7ATNkFs G1V2lRrMZAoXBx0A63CcCXcgHzckmRQUhnab37+33l/Wi3JGIcsuEEYV/QCQ7dyNFy u6ZGdorTClCtvX4YmrI5A+31w/T2ZDB73pltiNxiuMH9/Fu0RRJ8LNF8Pn+VlFr2Tv lvsDcR/t+gpyQ== Date: Tue, 18 Jul 2023 20:19:13 -0700 From: Jakub Kicinski To: Arkadiusz Kubalewski Cc: donald.hunter@gmail.com, netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com Subject: Re: [PATCH net-next v3 2/2] tools: ynl-gen: fix parse multi-attr enum attribute Message-ID: <20230718201913.632b6936@kernel.org> In-Reply-To: <20230718162225.231775-3-arkadiusz.kubalewski@intel.com> References: <20230718162225.231775-1-arkadiusz.kubalewski@intel.com> <20230718162225.231775-3-arkadiusz.kubalewski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 18 Jul 2023 18:22:25 +0200 Arkadiusz Kubalewski wrote: > + if 'enum' in attr_spec: > + decoded = self._decode_enum(int.from_bytes(attr.raw, "big"), attr_spec) why int.from_bytes(attr.raw, "big")? 'decoded' already holds the integer at this point