Re: [RFC PATCH 08/21] zram: Migrate to acomp compression API

Simon Horman
2023-07-21T09:22:56Z

On Tue, Jul 18, 2023 at 02:58:34PM +0200, Ard Biesheuvel wrote:

...

> @@ -1618,9 +1614,7 @@ static int zram_recompress(struct zram *zram, u32 index, struct page *page,
>
> num_recomps++;
> zstrm = zcomp_stream_get(zram->comps[prio]);
> - src = kmap_atomic(page);
> - ret = zcomp_compress(zstrm, src, &comp_len_new);
> - kunmap_atomic(src);
> + ret = zcomp_compress(zstrm, page, &comp_len_new);

Hi Ard,

src appears to be unused in this function with this change.

>
> if (ret) {
> zcomp_stream_put(zram->comps[prio]);

...