Re: [RFC PATCH 00/21] crypto: consolidate and clean up compression APIs

Herbert Xu
2023-07-28T10:07:18Z

On Fri, Jul 28, 2023 at 12:03:23PM +0200, Ard Biesheuvel wrote:
>
> Fair enough. But my point remains: this requires a lot of boilerplate
> on the part of the driver, and it would be better if we could do this
> in the acomp generic layer.

Absolutely. If the hardware can't support allocate-as-you-go then
this should very much go into the generic layer.

> Does the IPcomp case always know the decompressed size upfront?

No it doesn't know. Of course, we could optimise it because we know
that in 99% cases, the packet is going to be less than 4K. But we
need a safety-net for those weird jumbo packets.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt