Re: [PATCH net-next 7/8] can: kvaser_pciefd: Move hardware specific constants and functions into a driver_data struct

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

On 19.07.2023 08:53:04, Marc Kleine-Budde wrote:
> On 18.07.2023 18:33:15, Jakub Kicinski wrote:
> > On Mon, 17 Jul 2023 20:22:28 +0200 Marc Kleine-Budde wrote:
> > > +const struct kvaser_pciefd_address_offset kvaser_pciefd_altera_address_offset = {
> > 
> > > +const struct kvaser_pciefd_irq_mask kvaser_pciefd_altera_irq_mask = {
> > 
> > > +const struct kvaser_pciefd_dev_ops kvaser_pciefd_altera_dev_ops = {
> > 
> > > +const struct kvaser_pciefd_driver_data kvaser_pciefd_altera_driver_data = {
> > 
> > sparse points out the structs in this and subsequent patch should
> > be static. Would you be able to queue a quick fix on top and resend,
> > or should we pull as is?
> 
> Sorry, I'll post an updated pull request.

https://lore.kernel.org/all/20230719072348.525039-1-mkl@pengutronix.de

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]