From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BE38DF6F for ; Wed, 19 Jul 2023 10:02:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6BF1C433C8; Wed, 19 Jul 2023 10:02:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689760946; bh=7RLTkekLYGKgz6wXIqWeb2EVAaRvDY1n9b3KWZ0aoWw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eHm5tuLEJdXMsKlx+8Si04k5YF7xh4lGFThB6f6OtIFi2WSuJm3NGLBk++9jELfy2 e7tDLppm/ZAv+JjeovJwIimUHU1mDfm8Zl0XcJi4bMnHBWq95HwD9KcDhxm3vdVqwg AZZ1elo0Dj8Hy5ojCthJCTMEm4oQhdlFn9XlImACPjcZgJphIWL1lo8yS10qR65xbV iTJTOSlukaZThIscmxqfcgstw1czOIb+8gEK6+5c+2PKXS7Wm/tbEB/tYebA++RlLe vLL1xP+0H25YQ+1X9qtB20ZYeIWznb1lg5IEZ+4MdpDnh20cfv7px2ShSGUFYd/hPt EI13atBmjgZRA== Date: Wed, 19 Jul 2023 13:02:22 +0300 From: Leon Romanovsky To: Steffen Klassert Cc: Louis Peens , David Miller , Jakub Kicinski , Paolo Abeni , Herbert Xu , Simon Horman , Shihong Wang , netdev@vger.kernel.org, oss-drivers@corigine.com Subject: Re: [PATCH net-next 1/2] xfrm: add the description of CHACHA20-POLY1305 for xfrm algorithm description Message-ID: <20230719100222.GL8808@unreal> References: <20230719091830.50866-1-louis.peens@corigine.com> <20230719091830.50866-2-louis.peens@corigine.com> <20230719093509.GJ8808@unreal> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jul 19, 2023 at 11:51:41AM +0200, Steffen Klassert wrote: > On Wed, Jul 19, 2023 at 12:35:09PM +0300, Leon Romanovsky wrote: > > On Wed, Jul 19, 2023 at 11:27:27AM +0200, Steffen Klassert wrote: > > > On Wed, Jul 19, 2023 at 11:18:29AM +0200, Louis Peens wrote: > > > > From: Shihong Wang > > > > > > > > Add the description of CHACHA20-POLY1305 for xfrm algorithm description > > > > and set pfkey_supported to 1 so that xfrm supports that the algorithm > > > > can be offloaded to the NIC. > > > > > > > > Signed-off-by: Shihong Wang > > > > Acked-by: Simon Horman > > > > Signed-off-by: Louis Peens > > > > --- > > > > include/uapi/linux/pfkeyv2.h | 1 + > > > > net/xfrm/xfrm_algo.c | 9 ++++++++- > > > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/include/uapi/linux/pfkeyv2.h b/include/uapi/linux/pfkeyv2.h > > > > index 8abae1f6749c..d0ab530e1069 100644 > > > > --- a/include/uapi/linux/pfkeyv2.h > > > > +++ b/include/uapi/linux/pfkeyv2.h > > > > @@ -331,6 +331,7 @@ struct sadb_x_filter { > > > > #define SADB_X_EALG_CAMELLIACBC 22 > > > > #define SADB_X_EALG_NULL_AES_GMAC 23 > > > > #define SADB_X_EALG_SM4CBC 24 > > > > +#define SADB_X_EALG_CHACHA20_POLY1305 25 > > > > > > Please don't add new stuff to pfkey, use netlink instead. This interface > > > is deprecated and will go away someday > > > > Steffen, I have general questions. > > >From where did all these SADB_X_EALG_* values come? > > And there are they used? > > The pfkey interface was used by the old ipsec tools: > https://ipsec-tools.sourceforge.net/ > > The development of ipsec-tools has been abandoned > in 2014, as you can see at the webpage. Thanks