From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A02E11E507 for ; Fri, 21 Jul 2023 13:37:06 +0000 (UTC) Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C99310F5 for ; Fri, 21 Jul 2023 06:37:04 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3fbc244d307so17146175e9.1 for ; Fri, 21 Jul 2023 06:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1689946622; x=1690551422; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cyJTSHbeo76bzi6vElx+C7cII9lsbnhay7widihGytw=; b=zk1Ag3uPbpvIF+OjujPgm2Lry426dUcuFeJkaainc672cQ0u2V88zlLAKFj+30H1nv nCvnihrj0cNimAIROEjqxQRYg59jmE+e9f67u5bzXhAKqp9Wp2wsmqtEFbHhMW49vMiB lm73FUZFhW0c8HNVJQBZ836nxN+Ho1Ufh8x99SHaU5HKr0kxAIqKMLwv2K7Jr+0R2VDG BWrMOb5aR9dErBy0t20aCrE16oY8fugS/3x8L+2zzSvJduYbu6wRtMm38WWk8FjynLlw hrr2HdsJ33A/M8QCy7jaiETViUviVie+KrsFfb7T9HsyRctOQ+Jm0IarejMT5zNVBqjE Ue3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689946622; x=1690551422; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cyJTSHbeo76bzi6vElx+C7cII9lsbnhay7widihGytw=; b=N6CUzuzi9GnD3JSCn4g2bYUqvKZ71bwD6tsQdnmuTIFhk4JjESF7GQuD+Ofh11MC17 fpcGQcZWsjeX4ZEzS+PGBHMJ3o2Dn5r7onGK7N5ql84qVFCoDXU5tnsZCW/WuRpe+EHa nfyor01r1Ni1PweAmeOlCe3FOEkcEaHgmvzuPF/bes2EtSOJoa0CfMgpNqNEDCXDweBb 0A774xUcZHwd4+9ZAsqjwCcZKs3KF6aFseDqE8p8KowIG7R4qBFox63HIwIenV2oaHru fEyI+QZJ+x/OmedLZWkA1Q25FWsZMaijnTV8/g1vAxdqRGxewW5Bo3Mx0N5Zrw+bHe0c vhWg== X-Gm-Message-State: ABy/qLYAfe3L62baUcMa0oz7ZLw1lo61B/NSiI4v30eWkZt3aJPKrnsd aLTf4qW52zTzw6JxcFMNDN2xIQ== X-Google-Smtp-Source: APBJJlEamjH4SEwBOa7+/tDkX8IYcdS8z1RSOIETUrQMKtwEUtTm4XVENZbQn6tjOW7nZ1WOZ+STig== X-Received: by 2002:adf:fed2:0:b0:315:8f4f:81b8 with SMTP id q18-20020adffed2000000b003158f4f81b8mr1501101wrs.50.1689946622331; Fri, 21 Jul 2023 06:37:02 -0700 (PDT) Received: from blmsp ([2001:4091:a247:82fa:b762:4f68:e1ed:5041]) by smtp.gmail.com with ESMTPSA id v11-20020a1cf70b000000b003fbacc853ccsm3412568wmh.18.2023.07.21.06.37.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 06:37:01 -0700 (PDT) Date: Fri, 21 Jul 2023 15:37:00 +0200 From: Markus Schneider-Pargmann To: Simon Horman Cc: Marc Kleine-Budde , Chandrasekar Ramakrishnan , Wolfgang Grandegger , Vincent MAILHOL , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Julien Panis Subject: Re: [PATCH v5 12/12] can: m_can: Implement transmit submission coalescing Message-ID: <20230721133603.eahybmvzf4yalyn7@blmsp> References: <20230718075708.958094-1-msp@baylibre.com> <20230718075708.958094-13-msp@baylibre.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi Simon, On Thu, Jul 20, 2023 at 04:58:49PM +0100, Simon Horman wrote: > On Tue, Jul 18, 2023 at 09:57:08AM +0200, Markus Schneider-Pargmann wrote: > > m_can supports submitting multiple transmits with one register write. > > This is an interesting option to reduce the number of SPI transfers for > > peripheral chips. > > > > The m_can_tx_op is extended with a bool that signals if it is the last > > transmission and the submit should be executed immediately. > > > > The worker then writes the skb to the FIFO and submits it only if the > > submit bool is set. If it isn't set, the worker will write the next skb > > which is waiting in the workqueue to the FIFO, etc. > > > > Signed-off-by: Markus Schneider-Pargmann > > Reviewed-by: Simon Horman Thank you for your reviews! Best, Markus