From: valis <sec@valis.email>
To: netdev@vger.kernel.org
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, pctammela@mojatatu.com, victor@mojatatu.com,
ramdhan@starlabs.sg, billy@starlabs.sg
Subject: [PATCH net 0/3] net/sched Bind logic fixes for cls_fw, cls_u32 and cls_route
Date: Fri, 21 Jul 2023 17:48:53 +0000 [thread overview]
Message-ID: <20230721174856.3045-1-sec@valis.email> (raw)
Three classifiers (cls_fw, cls_u32 and cls_route) always copy
tcf_result struct into the new instance of the filter on update.
This causes a problem when updating a filter bound to a class,
as tcf_unbind_filter() is always called on the old instance in the
success path, decreasing filter_cnt of the still referenced class
and allowing it to be deleted, leading to a use-after-free.
This patch set fixes this issue in all affected classifiers by no longer
copying the tcf_result struct from the old filter.
valis (3):
net/sched: cls_u32: No longer copy tcf_result on update to avoid
use-after-free
net/sched: cls_fw: No longer copy tcf_result on update to avoid
use-after-free
net/sched: cls_route: No longer copy tcf_result on update to avoid
use-after-free
net/sched/cls_fw.c | 1 -
net/sched/cls_route.c | 1 -
net/sched/cls_u32.c | 1 -
3 files changed, 3 deletions(-)
--
2.30.2
next reply other threads:[~2023-07-21 17:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 17:48 valis [this message]
2023-07-21 17:48 ` [PATCH net 1/3] net/sched: cls_u32: No longer copy tcf_result on update to avoid use-after-free valis
2023-07-21 18:04 ` M A Ramdhan
2023-07-21 18:58 ` Pedro Tammela
2023-07-21 20:38 ` M A Ramdhan
2023-07-21 19:55 ` Jamal Hadi Salim
2023-07-21 17:48 ` [PATCH net 2/3] net/sched: cls_fw: " valis
2023-07-21 17:48 ` [PATCH net 3/3] net/sched: cls_route: " valis
2023-07-21 19:00 ` [PATCH net 0/3] net/sched Bind logic fixes for cls_fw, cls_u32 and cls_route Pedro Tammela
2023-07-21 19:56 ` Jamal Hadi Salim
2023-07-23 7:25 ` M A Ramdhan
2023-07-25 12:57 ` Paolo Abeni
2023-07-25 19:05 ` valis
2023-07-25 20:09 ` Jakub Kicinski
2023-07-25 21:36 ` valis
2023-07-25 22:03 ` Jakub Kicinski
2023-07-26 4:07 ` Greg Kroah-Hartman
2023-07-26 13:59 ` Jamal Hadi Salim
2023-07-26 15:25 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721174856.3045-1-sec@valis.email \
--to=sec@valis.email \
--cc=billy@starlabs.sg \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=ramdhan@starlabs.sg \
--cc=victor@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).