From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B79FB39E; Sat, 22 Jul 2023 01:29:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D365C433C9; Sat, 22 Jul 2023 01:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689989385; bh=R5mM7X0dWWGe8uUNwpNWWJBPRCjYazXGxXdFnAodWvw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HmuHP5XXPJ9OGtuSX0ZEUaobPZhKyyzy3vPE6pZquoHGaxKkuOBYJK6imJ3otDRay GckHYEcvBviIAOUIw3ZdJtbN6F1o2H+lCIY7cYQ6rlgStZ1JAPRyy4yzkpDWSw2rA5 iCEa/d1g0S86jnzKTU5948tooRNODGKE9yL97nmTfJCwL7CruJltGOB+Tq5ejSar8W G/DioqTgh+MEEAuF5EW/SrMesfAMaXhXwJFBpucPUUaC+OiyWaJm3lsjKMghTj/1pv ayRVX+l0X3k8Z/M+GfF9SEGp4PJL82byym5BcnsB8T6OOY3SH7KRPb+uo1nAaBHe1s 2T3QLRT6rdakg== Date: Fri, 21 Jul 2023 18:29:42 -0700 From: Jakub Kicinski To: Alexander Lobakin Cc: Yunsheng Lin , , , , , Eric Dumazet , Wei Fang , Shenwei Wang , Clark Wang , NXP Linux Team , Sunil Goutham , Geetha sowjanya , "Subbaraya Sundeep" , hariprasad , "Saeed Mahameed" , Leon Romanovsky , "Alexei Starovoitov" , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Kalle Valo , Matthias Brugger , AngeloGioacchino Del Regno , "Ilias Apalodimas" , , , , , Subject: Re: [PATCH net-next] page_pool: split types and declarations from page_pool.h Message-ID: <20230721182942.0ca57663@kernel.org> In-Reply-To: References: <20230719121339.63331-1-linyunsheng@huawei.com> <0838ed9e-8b5c-cc93-0175-9d6cbf695dda@intel.com> <7e9c1276-9996-d9dd-c061-b1e66361c48b@huawei.com> <20230720092247.279d65f3@kernel.org> <20230721075615.118acad4@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 21 Jul 2023 17:51:17 +0200 Alexander Lobakin wrote: > >> More specificly, yon means the below, right? > >> include/net/page_pool.h > >> include/net/page_pool/types.h > > > > Yes. > > What I meant is > > include/net/page_pool/types.h > include/net/page_pool/driver.h > > I'm not insisting, just to be clear :) I thought we already talked about naming headers after the user :S Unless you're _defining_ a driver in driver.h that's not a good name. types.h, helpers.h, functions.h, dma.h are good names.