From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96B39111B6 for ; Mon, 24 Jul 2023 21:42:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA461C433CA; Mon, 24 Jul 2023 21:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690234972; bh=+GmntWw2wj4TAgoks2s8GydM/ic6gHJYyYw6iUJJN68=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=H+wLCg95ppWbEdS/gfrkBlRJL8GSzxc5pnGAfcOUfCqEN0jcAhWlrIkNXkEC3eP9V 4RA9E4lO3ZGF+hOfMegtSn23YCDhyojHCyNgkVXqFYk9eu+baxpHppJoOkrTr52jLn ez+LUhhfunIyHZUIiw3NHW9jcuuqLDCACBzZCNJGtXGGY9z2S2sHMDkfPMfqRZw4LG UHv0q4Dj0l+J20fH9caBNk9dZUPoclp8h7oqB/Iub1OtT9bbdKVnZY7de9Sj59rdqI FJQRaJNZbicCz7Av3AIqmtyi+z9NHYB3g3pAXC07xvRXolW4cs3fNElExHqHWlZ568 g0B3u7NtW3weA== Date: Mon, 24 Jul 2023 14:42:50 -0700 From: Jakub Kicinski To: Matthew Wilcox Cc: Jann Horn , Suren Baghdasaryan , linux-mm@kvack.org, Arjun Roy , Eric Dumazet , linux-fsdevel@vger.kernel.org, Punit Agrawal , "David S. Miller" , Paolo Abeni , netdev@vger.kernel.org Subject: Re: [PATCH v2 1/9] Revert "tcp: Use per-vma locking for receive zerocopy" Message-ID: <20230724144250.4cef3f4e@kernel.org> In-Reply-To: References: <20230711202047.3818697-1-willy@infradead.org> <20230711202047.3818697-2-willy@infradead.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 24 Jul 2023 16:06:00 +0100 Matthew Wilcox wrote: > > Are you saying you want them to revert it before it reaches mainline? > > That commit landed in v6.5-rc1. > > ... what? It was posted on June 16th. How does it end up in rc1 on > July 9th? 6.4 was June 25th. 9 days is long enough for something > that's not an urgent fix to land in rc1? Networking doesn't close > development at rc5/6 like most subsystem trees? We don't, and yeah this one was a bit risky. We close for the merge window (the two weeks), we could definitely push back on risky changes starting a week or two before the window... but we don't know how long the release will last :( if we stop taking large changes at rc6 and release goes until rc8 that's 5 out of 11 weeks of the cycle when we can't apply substantial patches. It's way too long. The weeks after the merge window are already super stressful, if we shut down for longer it'll only get worse. I'm typing all this because I was hoping we can bring up making the release schedule even more predictable with Linus, I'm curious if others feel the same way. On the matter at hand - I thought the patches were just conflicting with your upcoming work. Are they already broken in v6.5? No problem with queuing the revert for v6.5 here if they are.