From: Jakub Kicinski <kuba@kernel.org>
To: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Cc: donald.hunter@gmail.com, netdev@vger.kernel.org,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
simon.horman@corigine.com
Subject: Re: [PATCH net-next v4 2/2] tools: ynl-gen: fix parse multi-attr enum attribute
Date: Mon, 24 Jul 2023 15:19:46 -0700 [thread overview]
Message-ID: <20230724151946.04deb72f@kernel.org> (raw)
In-Reply-To: <20230724102521.259545-3-arkadiusz.kubalewski@intel.com>
On Mon, 24 Jul 2023 12:25:21 +0200 Arkadiusz Kubalewski wrote:
> @@ -438,7 +438,7 @@ class YnlFamily(SpecFamily):
> decoded = attr.as_struct(members)
> for m in members:
> if m.enum:
> - self._decode_enum(decoded, m)
> + decoded[m.name] = self._decode_enum(decoded[m.name], m)
The indentation looks messed up here, otherwise LGTM.
--
pw-bot: cr
next prev parent reply other threads:[~2023-07-24 22:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 10:25 [PATCH net-next v4 0/2] tools: ynl-gen: fix parse multi-attr enum attribute Arkadiusz Kubalewski
2023-07-24 10:25 ` [PATCH net-next v4 1/2] tools: ynl-gen: fix enum index in _decode_enum(..) Arkadiusz Kubalewski
2023-07-24 10:25 ` [PATCH net-next v4 2/2] tools: ynl-gen: fix parse multi-attr enum attribute Arkadiusz Kubalewski
2023-07-24 22:19 ` Jakub Kicinski [this message]
2023-07-25 10:22 ` Kubalewski, Arkadiusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724151946.04deb72f@kernel.org \
--to=kuba@kernel.org \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).