From: Jakub Kicinski <kuba@kernel.org>
To: <Tristram.Ha@microchip.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Florian Fainelli <f.fainelli@gmail.com>,
<UNGLinuxDriver@microchip.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs
Date: Mon, 24 Jul 2023 16:43:51 -0700 [thread overview]
Message-ID: <20230724164351.2ecf6faf@kernel.org> (raw)
In-Reply-To: <1689900053-13118-1-git-send-email-Tristram.Ha@microchip.com>
On Thu, 20 Jul 2023 17:40:53 -0700 Tristram.Ha@microchip.com wrote:
> +#include <linux/inetdevice.h>
> +#include <net/addrconf.h>
> +#include <net/if_inet6.h>
> +#include <net/ipv6.h>
You don't need these includes any more, right?
> #include <linux/smscphy.h>
>
> /* Vendor-specific PHY Definitions */
> +static int lan874x_set_wol(struct phy_device *phydev,
> + struct ethtool_wolinfo *wol)
> +{
> + struct net_device *ndev = phydev->attached_dev;
> + struct smsc_phy_priv *priv = phydev->priv;
> + u16 val, val_wucsr;
> + u8 data[128];
> + u8 datalen;
> + int rc;
> +
> + if (wol->wolopts & WAKE_PHY)
> + return -EOPNOTSUPP;
You're not advertising the support for WAKE_PHY, so you don't have to
check if it was requested. See recent commit 55b24334c0f2.
Please keep the review tags from Florian and Simon for v6, these are
minor nit picks.
--
pw-bot: cr
next prev parent reply other threads:[~2023-07-24 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 0:40 [PATCH v5 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs Tristram.Ha
2023-07-24 11:50 ` Simon Horman
2023-07-24 15:35 ` Florian Fainelli
2023-07-24 23:43 ` Jakub Kicinski [this message]
2023-07-25 23:51 ` Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724164351.2ecf6faf@kernel.org \
--to=kuba@kernel.org \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).