From: Jakub Kicinski <kuba@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
workflows@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload
Date: Mon, 24 Jul 2023 18:04:28 -0700 [thread overview]
Message-ID: <20230724180428.783866cc@kernel.org> (raw)
In-Reply-To: <c690776ce6fd247c2b2aeb805744d5779b6293ab.camel@perches.com>
[clean up the CC list]
On Fri, 21 Jul 2023 20:32:44 -0700 Joe Perches wrote:
> On Fri, 2023-07-21 at 18:55 -0700, Jakub Kicinski wrote:
> > On Fri, 21 Jul 2023 18:21:32 +0200 Krzysztof Kozlowski wrote:
> > > That's not how you run it. get_maintainers.pl should be run on patches
> > > or on all files, not just some selection.
> >
> > Adding Joe for visibility (I proposed to print a warning when people
> > do this and IIRC he wasn't on board).
>
> What's the issue here? Other than _how_ the script was used,
> I don't see an actual problem with the script itself.
I just CCed you on another case. If people keep using get_maintainers
wrong, it *is* an issue with the script.
> I use the scripts below to send patch series where a patch series
> are the only files in individual directories.
The fact that most people end up wrapping get_maintainers in another
script is also a pretty strong indication that the user experience is
inadequate.
To be clear - I'm happy to put in the work to make the changes.
It's just that from past experience you seem to have strong opinions
which run counter to maintainers' needs, and I don't really enjoy
writing Perl for the sake of it.
next prev parent reply other threads:[~2023-07-25 1:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230721062617.9810-1-boon.khai.ng@intel.com>
[not found] ` <20230721062617.9810-2-boon.khai.ng@intel.com>
2023-07-21 10:10 ` [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload Krzysztof Kozlowski
2023-07-21 15:28 ` Ng, Boon Khai
2023-07-21 16:21 ` Krzysztof Kozlowski
2023-07-21 16:33 ` Ng, Boon Khai
2023-07-22 1:55 ` Jakub Kicinski
2023-07-22 3:32 ` Joe Perches
2023-07-25 1:04 ` Jakub Kicinski [this message]
2023-07-25 3:53 ` Joe Perches
2023-07-25 7:33 ` Geert Uytterhoeven
2023-07-25 13:19 ` Mario Limonciello
2023-07-25 13:43 ` Joe Perches
2023-07-25 14:37 ` Krzysztof Kozlowski
2023-07-25 15:59 ` [PATCH] scripts: checkpatch: steer people away from using file paths Jakub Kicinski
2023-07-25 16:53 ` Greg KH
2023-07-25 17:10 ` Jakub Kicinski
2023-07-25 17:25 ` Greg KH
2023-07-25 19:52 ` Jakub Kicinski
2023-07-25 21:01 ` Joe Perches
2023-07-25 16:57 ` Krzysztof Kozlowski
2023-07-25 21:18 ` Joe Perches
2023-07-25 22:15 ` Jakub Kicinski
2023-07-26 6:28 ` Joe Perches
2023-07-21 16:26 ` [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload Krzysztof Kozlowski
2023-07-21 16:39 ` Ng, Boon Khai
2023-07-21 10:17 ` Shevchenko Andriy
2023-07-21 15:35 ` Ng, Boon Khai
2023-07-21 15:48 ` Shevchenko, Andriy
2023-07-21 15:51 ` Ng, Boon Khai
[not found] ` <20230721062617.9810-3-boon.khai.ng@intel.com>
2023-07-21 10:11 ` [Enable Designware XGMAC VLAN Stripping Feature 2/2] net: stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping Krzysztof Kozlowski
2023-07-21 15:30 ` Ng, Boon Khai
2023-07-21 15:59 ` Florian Fainelli
2023-07-21 16:12 ` Ng, Boon Khai
2023-07-21 16:29 ` Florian Fainelli
2023-07-21 16:45 ` Ng, Boon Khai
2023-07-21 16:22 ` Krzysztof Kozlowski
2023-07-21 16:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724180428.783866cc@kernel.org \
--to=kuba@kernel.org \
--cc=joe@perches.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).