From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0CB21F188;
	Tue, 25 Jul 2023 21:28:13 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADB03C433C7;
	Tue, 25 Jul 2023 21:28:12 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1690320493;
	bh=MlVasKHUR67c8YAUaXJTiStk2sj8JIq65rkbxf8GQDs=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=YVe5VQBtbrwoSD8W5d5GkTH5OY7Q+4U285lD7Wx+E/a93wFdw9JV6cnK4RW2XskfX
	 kubj3MFPvztw8G3FMQf7GwZ9Fdzsdyw3fei7b3L2vccVXaXAShDHm4JpUkn3bTY4pd
	 iTMetUQ0PvpsK+u3Zt3rMI/9sZV7VsnaGVy/leWmr7VsduoPNIM/0hj8Ro2NUhhOpC
	 SdL8EKXw/ZB9kRB3sDlOCtA97HP1gCG+JVeQF0rbR5OWtclUbk7HgN3+Gwg/oAsP9C
	 75vdOsOlU3pJZrCLFI/qfNF4Gj+QfI18G2pfTM7L8nnb0fHYRIoHKxnSfBJ5334G2b
	 3NloLyLtZP+UQ==
Date: Tue, 25 Jul 2023 14:28:11 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <sdf@google.com>
Cc: Simon Horman <simon.horman@corigine.com>, bpf@vger.kernel.org,
 ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
 martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
 john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com,
 jolsa@kernel.org, toke@kernel.org, willemb@google.com, dsahern@kernel.org,
 magnus.karlsson@intel.com, bjorn@kernel.org, maciej.fijalkowski@intel.com,
 hawk@kernel.org, netdev@vger.kernel.org, xdp-hints@xdp-project.net
Subject: Re: [RFC net-next v4 2/8] xsk: add TX timestamp and TX checksum
 offload support
Message-ID: <20230725142811.07f4faa2@kernel.org>
In-Reply-To: <ZMAxAmg187DgPCAr@google.com>
References: <20230724235957.1953861-1-sdf@google.com>
	<20230724235957.1953861-3-sdf@google.com>
	<ZMAiYibjYzVTBjEF@corigine.com>
	<ZMAxAmg187DgPCAr@google.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 25 Jul 2023 13:30:58 -0700 Stanislav Fomichev wrote:
> > I know that it isn't the practice in this file.
> > but adding the following makes kernel-doc happier
> > about NETDEV_XSK_FLAGS_MASK not being documented.
> > 
> > 	/* private: */  
> 
> This is autogenerated file :-( But I guess I can try to extend ynl
> scripts to put this comment before the mask. Let me look into that...

Yes, please! I think I even wrote a patch for it at some point...
but then we realized that enums didn't support /* private: */.
Commit e27cb89a22ada4 has added the support, so we can get back
to getting the YNL changes in place.