From: Patrick Rohr <prohr@google.com>
To: "David S . Miller" <davem@davemloft.net>
Cc: Linux Network Development Mailing List <netdev@vger.kernel.org>,
Patrick Rohr <prohr@google.com>
Subject: [PATCH] net: move comment in ndisc_router_discovery
Date: Tue, 25 Jul 2023 11:51:51 -0700 [thread overview]
Message-ID: <20230725185151.37310-1-prohr@google.com> (raw)
Move setting the received flag comment to the appropriate section.
Signed-off-by: Patrick Rohr <prohr@google.com>
---
net/ipv6/ndisc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index eeb60888187f..0a29a4626194 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1266,10 +1266,6 @@ static enum skb_drop_reason ndisc_router_discovery(struct sk_buff *skb)
}
#endif
- /*
- * set the RA_RECV flag in the interface
- */
-
in6_dev = __in6_dev_get(skb->dev);
if (!in6_dev) {
ND_PRINTK(0, err, "RA: can't find inet6 device for %s\n",
@@ -1297,6 +1293,10 @@ static enum skb_drop_reason ndisc_router_discovery(struct sk_buff *skb)
}
#endif
+ /*
+ * set the RA_RECV flag in the interface
+ */
+
if (in6_dev->if_flags & IF_RS_SENT) {
/*
* flag that an RA was received after an RS was sent
--
2.41.0.487.g6d72f3e995-goog
next reply other threads:[~2023-07-25 18:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 18:51 Patrick Rohr [this message]
2023-07-25 23:21 ` [PATCH] net: move comment in ndisc_router_discovery David Ahern
2023-07-26 18:47 ` [PATCH v2] net: remove " Patrick Rohr
2023-07-27 12:04 ` Simon Horman
2023-07-27 15:18 ` David Ahern
2023-07-28 0:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725185151.37310-1-prohr@google.com \
--to=prohr@google.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).