From: Stephen Hemminger <stephen@networkplumber.org>
To: "Nicolas Escande" <nico.escande@gmail.com>
Cc: <netdev@vger.kernel.org>
Subject: Re: [iproute2] bridge: link: allow filtering on bridge name
Date: Tue, 25 Jul 2023 19:16:05 -0700 [thread overview]
Message-ID: <20230725191605.3ca8e599@hermes.local> (raw)
In-Reply-To: <CUBL17I9Z3W5.1XR1LVI9CRDDU@syracuse>
On Tue, 25 Jul 2023 23:48:16 +0200
"Nicolas Escande" <nico.escande@gmail.com> wrote:
> On Tue Jul 25, 2023 at 6:37 PM CEST, Stephen Hemminger wrote:
> > On Tue, 25 Jul 2023 11:22:42 +0200
> > Nicolas Escande <nico.escande@gmail.com> wrote:
> >
> > > When using 'brige link show' we can either dump all links enslaved to any bridge
> > > (called without arg ) or display a single link (called with dev arg).
> > > However there is no way to dummp all links of a single bridge.
> > >
> > > To do so, this adds new optional 'master XXX' arg to 'bridge link show' command.
> > > usage: bridge link show master br0
> > >
> > > Signed-off-by: Nicolas Escande <nico.escande@gmail.com>
> >
> > Looks good to me, but we really need to address removing the term master
> > from bridge utility.
>
> If you have a better term I can respin it.
> But the thing is 'master' is still the most widely used and understood word when
> it comes to bridge terminology. And as you said we have it in the output of many
> 'ip' and 'bridge' commands, that why IMHO it's the term we should use for now...
Leave it there for now. Only Linux uses the term master.
FreeBSD and other use the term adding interface to bridge (addm)
IEEE uses the term relay mostly.
You won't find the terms master/slave in any current spec.
> On another note, there is a slight indentation problem in the new if in
> print_linkinfo(), if that can be corrected when the patch gets picked up that
> would be perfect, otherwise I can send a v2.
Send a v2, that would be easier
next prev parent reply other threads:[~2023-07-26 2:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 9:22 [iproute2] bridge: link: allow filtering on bridge name Nicolas Escande
2023-07-25 16:37 ` Stephen Hemminger
2023-07-25 21:48 ` Nicolas Escande
2023-07-26 2:16 ` Stephen Hemminger [this message]
2023-07-26 7:11 ` Nicolas Escande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725191605.3ca8e599@hermes.local \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=nico.escande@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).