From: Jakub Kicinski <kuba@kernel.org>
To: "mengyuanlou@net-swift.com" <mengyuanlou@net-swift.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: ngbe: add ncsi_enable flag for wangxun nics
Date: Tue, 25 Jul 2023 19:44:56 -0700 [thread overview]
Message-ID: <20230725194456.7832c02d@kernel.org> (raw)
In-Reply-To: <6D0E96D7-CDF4-4889-831D-B83388035A2C@net-swift.com>
On Wed, 26 Jul 2023 09:59:15 +0800 mengyuanlou@net-swift.com wrote:
> > 2023年7月26日 07:22，Jakub Kicinski <kuba@kernel.org> 写道：
> > On Mon, 24 Jul 2023 17:24:58 +0800 Mengyuan Lou wrote:
> >> + netdev->ncsi_enabled = wx->ncsi_hw_supported;
> >
> > I don't think that enabled and supported are the same thing.
> > If server has multiple NICs or a NIC with multiple ports and
> > BMC only uses one, or even none, we shouldn't keep the PHY up.
> > By that logic 99% of server NICs should report NCSI as enabled.
>
> For a NIC with multiple ports, BMC switch connection for port0 to port1 online,
> Drivers can not know port1 should keep up, if do not set ncsi_enabled before.
I'm not crystal clear on what you're saying. But BMC sends a enable
command to the NIC to enable a channel (or some such). This is all
handled by FW. The FW can tell the host that the NCSI is now active
on port1 and not port0.
next prev parent reply other threads:[~2023-07-26 2:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230724092544.73531-1-mengyuanlou@net-swift.com>
2023-07-24 9:24 ` [PATCH net-next 1/2] net: ngbe: add ncsi_enable flag for wangxun nics Mengyuan Lou
2023-07-25 23:22 ` Jakub Kicinski
2023-07-26 1:59 ` mengyuanlou
2023-07-26 2:44 ` Jakub Kicinski [this message]
2023-07-26 3:12 ` mengyuanlou
2023-07-26 3:23 ` Jakub Kicinski
2023-07-24 9:24 ` [PATCH net-next 2/2] net: phy: add keep_data_connection to struct phydev Mengyuan Lou
2023-07-25 12:05 ` Simon Horman
2023-07-25 13:12 ` Russell King (Oracle)
2023-07-26 2:35 ` mengyuanlou
2023-07-26 8:10 ` Russell King (Oracle)
2023-07-26 8:54 ` Andrew Lunn
2023-07-26 16:08 ` Jakub Kicinski
2023-07-26 16:43 ` Andrew Lunn
2023-07-26 18:29 ` Jakub Kicinski
2023-07-28 9:27 ` mengyuanlou
2023-07-28 9:48 ` Andrew Lunn
2023-07-28 15:11 ` Jakub Kicinski
2023-07-25 12:13 ` [PATCH net-next 1/2] net: ngbe: add ncsi_enable flag for wangxun nics Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725194456.7832c02d@kernel.org \
--to=kuba@kernel.org \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).