From: Shenwei Wang <shenwei.wang@nxp.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Russell King <linux@armlinux.org.uk>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
Shenwei Wang <shenwei.wang@nxp.com>, Frank Li <frank.li@nxp.com>
Subject: [PATCH] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link
Date: Tue, 25 Jul 2023 14:49:31 -0500 [thread overview]
Message-ID: <20230725194931.1989102-1-shenwei.wang@nxp.com> (raw)
When using a fixed-link setup, certain devices like the SJA1105 require a
small pause in the TXC clock line to enable their internal tunable
delay line (TDL).
To satisfy this requirement, this patch temporarily disables the TX clock,
and restarts it after a required period. This provides the required
silent interval on the clock line for SJA1105 to complete the frequency
transition and enable the internal TDLs.
So far we have only enabled this feature on the i.MX93 platform.
Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
Reviewed-by: Frank Li <frank.li@nxp.com>
---
.../net/ethernet/stmicro/stmmac/dwmac-imx.c | 62 +++++++++++++++++++
1 file changed, 62 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
index b9378a63f0e8..799aedeec094 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-imx.c
@@ -40,6 +40,9 @@
#define DMA_BUS_MODE 0x00001000
#define DMA_BUS_MODE_SFT_RESET (0x1 << 0)
#define RMII_RESET_SPEED (0x3 << 14)
+#define TEN_BASET_RESET_SPEED (0x2 << 14)
+#define RGMII_RESET_SPEED (0x0 << 14)
+#define CTRL_SPEED_MASK (0x3 << 14)
struct imx_dwmac_ops {
u32 addr_width;
@@ -56,6 +59,7 @@ struct imx_priv_data {
struct regmap *intf_regmap;
u32 intf_reg_off;
bool rmii_refclk_ext;
+ void __iomem *base_addr;
const struct imx_dwmac_ops *ops;
struct plat_stmmacenet_data *plat_dat;
@@ -212,6 +216,61 @@ static void imx_dwmac_fix_speed(void *priv, unsigned int speed)
dev_err(dwmac->dev, "failed to set tx rate %lu\n", rate);
}
+static bool imx_dwmac_is_fixed_link(struct imx_priv_data *dwmac)
+{
+ struct plat_stmmacenet_data *plat_dat;
+ struct device_node *dn;
+
+ if (!dwmac || !dwmac->plat_dat)
+ return false;
+
+ plat_dat = dwmac->plat_dat;
+ dn = of_get_child_by_name(dwmac->dev->of_node, "fixed-link");
+ if (!dn)
+ return false;
+
+ if (plat_dat->phy_node == dn || plat_dat->phylink_node == dn)
+ return true;
+
+ return false;
+}
+
+static void imx_dwmac_fix_speed_mx93(void *priv, unsigned int speed)
+{
+ struct plat_stmmacenet_data *plat_dat;
+ struct imx_priv_data *dwmac = priv;
+ int val, ctrl, old_ctrl;
+
+ imx_dwmac_fix_speed(priv, speed);
+
+ old_ctrl = readl(dwmac->base_addr + MAC_CTRL_REG);
+ plat_dat = dwmac->plat_dat;
+ ctrl = old_ctrl & ~CTRL_SPEED_MASK;
+
+ /* by default ctrl will be SPEED_1000 */
+ if (speed == SPEED_100)
+ ctrl |= RMII_RESET_SPEED;
+ if (speed == SPEED_10)
+ ctrl |= TEN_BASET_RESET_SPEED;
+
+ if (imx_dwmac_is_fixed_link(dwmac)) {
+ writel(ctrl, dwmac->base_addr + MAC_CTRL_REG);
+
+ /* Ensure the settings for CTRL are applied */
+ wmb();
+
+ val = MX93_GPR_ENET_QOS_INTF_SEL_RGMII;
+ regmap_update_bits(dwmac->intf_regmap, dwmac->intf_reg_off,
+ MX93_GPR_ENET_QOS_INTF_MODE_MASK, val);
+ usleep_range(50, 100);
+ val = MX93_GPR_ENET_QOS_INTF_SEL_RGMII | MX93_GPR_ENET_QOS_CLK_GEN_EN;
+ regmap_update_bits(dwmac->intf_regmap, dwmac->intf_reg_off,
+ MX93_GPR_ENET_QOS_INTF_MODE_MASK, val);
+
+ writel(old_ctrl, dwmac->base_addr + MAC_CTRL_REG);
+ }
+}
+
static int imx_dwmac_mx93_reset(void *priv, void __iomem *ioaddr)
{
struct plat_stmmacenet_data *plat_dat = priv;
@@ -317,8 +376,11 @@ static int imx_dwmac_probe(struct platform_device *pdev)
plat_dat->exit = imx_dwmac_exit;
plat_dat->clks_config = imx_dwmac_clks_config;
plat_dat->fix_mac_speed = imx_dwmac_fix_speed;
+ if (of_machine_is_compatible("fsl,imx93"))
+ plat_dat->fix_mac_speed = imx_dwmac_fix_speed_mx93;
plat_dat->bsp_priv = dwmac;
dwmac->plat_dat = plat_dat;
+ dwmac->base_addr = stmmac_res.addr;
ret = imx_dwmac_clks_config(dwmac, true);
if (ret)
--
2.34.1
next reply other threads:[~2023-07-25 19:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 19:49 Shenwei Wang [this message]
2023-07-25 21:04 ` [PATCH] net: stmmac: dwmac-imx: pause the TXC clock in fixed-link Russell King (Oracle)
2023-07-26 15:00 ` [EXT] " Shenwei Wang
2023-07-26 15:09 ` Russell King (Oracle)
2023-07-26 16:10 ` Shenwei Wang
2023-07-26 16:29 ` Russell King (Oracle)
2023-07-26 17:03 ` Vladimir Oltean
2023-07-26 18:24 ` Shenwei Wang
2023-07-26 18:30 ` Andrew Lunn
2023-07-25 23:23 ` kernel test robot
2023-07-26 0:43 ` Vladimir Oltean
2023-07-26 15:10 ` [EXT] " Shenwei Wang
2023-07-26 15:29 ` Russell King (Oracle)
2023-07-26 15:59 ` Shenwei Wang
2023-07-26 17:01 ` Russell King (Oracle)
2023-07-26 18:47 ` Shenwei Wang
2023-07-26 19:02 ` Russell King (Oracle)
2023-07-26 19:17 ` Shenwei Wang
2023-07-27 8:58 ` Russell King (Oracle)
2023-07-27 13:03 ` Shenwei Wang
2023-07-26 8:32 ` Andrew Lunn
2023-07-26 11:58 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725194931.1989102-1-shenwei.wang@nxp.com \
--to=shenwei.wang@nxp.com \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).