* [PATCH -next] nf_conntrack: fix -Wunused-const-variable=
@ 2023-07-26 10:15 Zhu Wang
2023-07-26 12:53 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Zhu Wang @ 2023-07-26 10:15 UTC (permalink / raw)
To: pablo, kadlec, fw, davem, edumazet, kuba, pabeni, kaber,
netfilter-devel, coreteam, netdev, linux-kernel
Cc: wangzhu9
When building with W=1, the following warning occurs.
net/netfilter/nf_conntrack_proto_dccp.c:72:27: warning: ‘dccp_state_names’ defined but not used [-Wunused-const-variable=]
static const char * const dccp_state_names[] = {
We include dccp_state_names in the macro
CONFIG_NF_CONNTRACK_PROCFS, since it is only used in the place
which is included in the macro CONFIG_NF_CONNTRACK_PROCFS.
Fixes: 2bc780499aa3 ("[NETFILTER]: nf_conntrack: add DCCP protocol support")
Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
---
net/netfilter/nf_conntrack_proto_dccp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/netfilter/nf_conntrack_proto_dccp.c b/net/netfilter/nf_conntrack_proto_dccp.c
index d4fd626d2b8c..e2db1f4ec2df 100644
--- a/net/netfilter/nf_conntrack_proto_dccp.c
+++ b/net/netfilter/nf_conntrack_proto_dccp.c
@@ -69,6 +69,7 @@
#define DCCP_MSL (2 * 60 * HZ)
+#ifdef CONFIG_NF_CONNTRACK_PROCFS
static const char * const dccp_state_names[] = {
[CT_DCCP_NONE] = "NONE",
[CT_DCCP_REQUEST] = "REQUEST",
@@ -81,6 +82,7 @@ static const char * const dccp_state_names[] = {
[CT_DCCP_IGNORE] = "IGNORE",
[CT_DCCP_INVALID] = "INVALID",
};
+#endif
#define sNO CT_DCCP_NONE
#define sRQ CT_DCCP_REQUEST
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] nf_conntrack: fix -Wunused-const-variable=
2023-07-26 10:15 [PATCH -next] nf_conntrack: fix -Wunused-const-variable= Zhu Wang
@ 2023-07-26 12:53 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2023-07-26 12:53 UTC (permalink / raw)
To: Zhu Wang
Cc: pablo, kadlec, fw, davem, edumazet, kuba, pabeni, kaber,
netfilter-devel, coreteam, netdev, linux-kernel
On Wed, Jul 26, 2023 at 06:15:31PM +0800, Zhu Wang wrote:
> When building with W=1, the following warning occurs.
>
> net/netfilter/nf_conntrack_proto_dccp.c:72:27: warning: ‘dccp_state_names’ defined but not used [-Wunused-const-variable=]
> static const char * const dccp_state_names[] = {
>
> We include dccp_state_names in the macro
> CONFIG_NF_CONNTRACK_PROCFS, since it is only used in the place
> which is included in the macro CONFIG_NF_CONNTRACK_PROCFS.
>
> Fixes: 2bc780499aa3 ("[NETFILTER]: nf_conntrack: add DCCP protocol support")
> Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-26 12:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-26 10:15 [PATCH -next] nf_conntrack: fix -Wunused-const-variable= Zhu Wang
2023-07-26 12:53 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).