From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E64D81BEF1 for ; Wed, 26 Jul 2023 21:09:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35B81C433C8; Wed, 26 Jul 2023 21:09:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690405782; bh=mQq2biQR8y/tg4kRgcCOfzcSSkHg/EcJfyRdllIr2Dw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=q2WEOM/u+/oCPrSFPnLa4UHb4aJvm4hmjv9nhsX0a+3vzR36n9Jp9vthDyDTD0fxb idZsn10T5hnManAZqEN+Y5usaVp7wqFLiac1wvBOv4NgsA2TqrbPlgAboCK7uRe1VL E0bn6Y0ZLo46/rD8yZkV2X8ocs3S1Og6DvR6DttZ9cKvWLymrjzzgLuOSmgNHs90Ws FC7l2oL1mugg17LKUUIuemhVB+a0L+nnJ04vLkn3+Lg161qR54Dt+LJVarv8dPVQUb E/2aRMy9JmziCPcChFp6ohmTiXFPmKHzkQJ3QHCSx3MSoWb6aMvsVPfqcpT7tIaU+B nZTZv3Px9efLA== Date: Wed, 26 Jul 2023 14:09:41 -0700 From: Jakub Kicinski To: Donald Hunter Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , donald.hunter@redhat.com Subject: Re: [PATCH net-next v1 1/3] doc/netlink: Add a schema for netlink-raw families Message-ID: <20230726140941.2ef8f870@kernel.org> In-Reply-To: <20230725162205.27526-2-donald.hunter@gmail.com> References: <20230725162205.27526-1-donald.hunter@gmail.com> <20230725162205.27526-2-donald.hunter@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 25 Jul 2023 17:22:03 +0100 Donald Hunter wrote: > - add an id property to mcast-group definitions nit: my first thought would be to call it "value" rather than "id" to stick with the naming we have to other objects. Any pros/cons you see? Other than that the big ask would be to update the documentation :)