From: Jakub Kicinski <kuba@kernel.org>
To: Stanislav Fomichev <sdf@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com
Subject: Re: [PATCH net-next 2/4] ynl: mark max/mask as private for kdoc
Date: Wed, 26 Jul 2023 16:33:17 -0700 [thread overview]
Message-ID: <20230726163317.6f120200@kernel.org> (raw)
In-Reply-To: <20230725233517.2614868-3-sdf@google.com>
On Tue, 25 Jul 2023 16:35:15 -0700 Stanislav Fomichev wrote:
> + cw.p('/* private: */')
> cw.nl()
I was about to apply but I keep having doubts whether there should
be a new line after the private marker. I know - a very important
question :D
Quick grep of
$ git grep -A1 '\* private:'
shows that all(?) current uses have something immediately following
the comment.
next prev parent reply other threads:[~2023-07-26 23:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 23:35 [PATCH net-next 0/4] ynl: couple of unrelated fixes Stanislav Fomichev
2023-07-25 23:35 ` [PATCH net-next 1/4] ynl: expose xdp-zc-max-segs Stanislav Fomichev
2023-07-25 23:35 ` [PATCH net-next 2/4] ynl: mark max/mask as private for kdoc Stanislav Fomichev
2023-07-26 23:33 ` Jakub Kicinski [this message]
2023-07-26 23:35 ` Stanislav Fomichev
2023-07-25 23:35 ` [PATCH net-next 3/4] ynl: regenerate all headers Stanislav Fomichev
2023-07-26 23:37 ` Jakub Kicinski
2023-07-26 23:55 ` Stanislav Fomichev
2023-07-27 0:22 ` Jakub Kicinski
2023-07-25 23:35 ` [PATCH net-next 4/4] ynl: print xdp-zc-max-segs in the sample Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726163317.6f120200@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).