* [PATCH] net: move comment in ndisc_router_discovery
@ 2023-07-25 18:51 Patrick Rohr
2023-07-25 23:21 ` David Ahern
0 siblings, 1 reply; 6+ messages in thread
From: Patrick Rohr @ 2023-07-25 18:51 UTC (permalink / raw)
To: David S . Miller; +Cc: Linux Network Development Mailing List, Patrick Rohr
Move setting the received flag comment to the appropriate section.
Signed-off-by: Patrick Rohr <prohr@google.com>
---
net/ipv6/ndisc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index eeb60888187f..0a29a4626194 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1266,10 +1266,6 @@ static enum skb_drop_reason ndisc_router_discovery(struct sk_buff *skb)
}
#endif
- /*
- * set the RA_RECV flag in the interface
- */
-
in6_dev = __in6_dev_get(skb->dev);
if (!in6_dev) {
ND_PRINTK(0, err, "RA: can't find inet6 device for %s\n",
@@ -1297,6 +1293,10 @@ static enum skb_drop_reason ndisc_router_discovery(struct sk_buff *skb)
}
#endif
+ /*
+ * set the RA_RECV flag in the interface
+ */
+
if (in6_dev->if_flags & IF_RS_SENT) {
/*
* flag that an RA was received after an RS was sent
--
2.41.0.487.g6d72f3e995-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] net: move comment in ndisc_router_discovery
2023-07-25 18:51 [PATCH] net: move comment in ndisc_router_discovery Patrick Rohr
@ 2023-07-25 23:21 ` David Ahern
2023-07-26 18:47 ` [PATCH v2] net: remove " Patrick Rohr
0 siblings, 1 reply; 6+ messages in thread
From: David Ahern @ 2023-07-25 23:21 UTC (permalink / raw)
To: Patrick Rohr, David S . Miller; +Cc: Linux Network Development Mailing List
On 7/25/23 12:51 PM, Patrick Rohr wrote:
> Move setting the received flag comment to the appropriate section.
>
> Signed-off-by: Patrick Rohr <prohr@google.com>
> ---
> net/ipv6/ndisc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
> index eeb60888187f..0a29a4626194 100644
> --- a/net/ipv6/ndisc.c
> +++ b/net/ipv6/ndisc.c
> @@ -1266,10 +1266,6 @@ static enum skb_drop_reason ndisc_router_discovery(struct sk_buff *skb)
> }
> #endif
>
> - /*
> - * set the RA_RECV flag in the interface
> - */
> -
> in6_dev = __in6_dev_get(skb->dev);
> if (!in6_dev) {
> ND_PRINTK(0, err, "RA: can't find inet6 device for %s\n",
> @@ -1297,6 +1293,10 @@ static enum skb_drop_reason ndisc_router_discovery(struct sk_buff *skb)
> }
> #endif
>
> + /*
> + * set the RA_RECV flag in the interface
> + */
> +
> if (in6_dev->if_flags & IF_RS_SENT) {
> /*
> * flag that an RA was received after an RS was sent
There is already a comment here, so just delete the previous one.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] net: remove comment in ndisc_router_discovery
2023-07-25 23:21 ` David Ahern
@ 2023-07-26 18:47 ` Patrick Rohr
2023-07-27 12:04 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Patrick Rohr @ 2023-07-26 18:47 UTC (permalink / raw)
To: David S . Miller; +Cc: Linux Network Development Mailing List, Patrick Rohr
Removes superfluous (and misplaced) comment from ndisc_router_discovery.
Signed-off-by: Patrick Rohr <prohr@google.com>
---
net/ipv6/ndisc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index eeb60888187f..c394799be38f 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1266,10 +1266,6 @@ static enum skb_drop_reason ndisc_router_discovery(struct sk_buff *skb)
}
#endif
- /*
- * set the RA_RECV flag in the interface
- */
-
in6_dev = __in6_dev_get(skb->dev);
if (!in6_dev) {
ND_PRINTK(0, err, "RA: can't find inet6 device for %s\n",
--
2.41.0.487.g6d72f3e995-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] net: remove comment in ndisc_router_discovery
2023-07-26 18:47 ` [PATCH v2] net: remove " Patrick Rohr
@ 2023-07-27 12:04 ` Simon Horman
2023-07-27 15:18 ` David Ahern
2023-07-28 0:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2023-07-27 12:04 UTC (permalink / raw)
To: Patrick Rohr; +Cc: David S . Miller, Linux Network Development Mailing List
On Wed, Jul 26, 2023 at 11:47:42AM -0700, Patrick Rohr wrote:
> Removes superfluous (and misplaced) comment from ndisc_router_discovery.
>
> Signed-off-by: Patrick Rohr <prohr@google.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] net: remove comment in ndisc_router_discovery
2023-07-26 18:47 ` [PATCH v2] net: remove " Patrick Rohr
2023-07-27 12:04 ` Simon Horman
@ 2023-07-27 15:18 ` David Ahern
2023-07-28 0:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 6+ messages in thread
From: David Ahern @ 2023-07-27 15:18 UTC (permalink / raw)
To: Patrick Rohr, David S . Miller; +Cc: Linux Network Development Mailing List
On 7/26/23 12:47 PM, Patrick Rohr wrote:
> Removes superfluous (and misplaced) comment from ndisc_router_discovery.
>
> Signed-off-by: Patrick Rohr <prohr@google.com>
> ---
> net/ipv6/ndisc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] net: remove comment in ndisc_router_discovery
2023-07-26 18:47 ` [PATCH v2] net: remove " Patrick Rohr
2023-07-27 12:04 ` Simon Horman
2023-07-27 15:18 ` David Ahern
@ 2023-07-28 0:10 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-28 0:10 UTC (permalink / raw)
To: Patrick Rohr; +Cc: davem, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 26 Jul 2023 11:47:42 -0700 you wrote:
> Removes superfluous (and misplaced) comment from ndisc_router_discovery.
>
> Signed-off-by: Patrick Rohr <prohr@google.com>
> ---
> net/ipv6/ndisc.c | 4 ----
> 1 file changed, 4 deletions(-)
Here is the summary with links:
- [v2] net: remove comment in ndisc_router_discovery
https://git.kernel.org/netdev/net-next/c/ef27ba5c845d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-28 0:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 18:51 [PATCH] net: move comment in ndisc_router_discovery Patrick Rohr
2023-07-25 23:21 ` David Ahern
2023-07-26 18:47 ` [PATCH v2] net: remove " Patrick Rohr
2023-07-27 12:04 ` Simon Horman
2023-07-27 15:18 ` David Ahern
2023-07-28 0:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).