From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4138F1BEE3 for ; Wed, 26 Jul 2023 21:32:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 047ABC433C8; Wed, 26 Jul 2023 21:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690407131; bh=JGGrB4NwV2vAix+LnjMOouDpWo1lR8GK79P8ZkAEGlE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gkrhx066qZflPTR3O9va0VEtdN9lH7RnBnea+WrMsXi4jYHJeCngAmgNPg+xpfohd l13UQHejR2Unoar8wNadpIJUX6TNqynCe8vYce5tNo5MATC7oN0+l4Y3/94SdAoqyc C+7+d1zZr/uNSkk3A6oEL5ExdwnGqgaaw6L5gsAhnD3FpOlpGmiL6VLjzDrtlHI3TK /iDvn4NOt4OB/KGWRdUnTOPlYGsAUYa6gffloUj6XSJaxIGkptewsjbXFY6CANlpfA il86L33o/vg/D0CkK2PftmtJQKzwAmgx80QU1dNplS9zMh2GO5QFpmoDm0Po2p9Qzq RufVHcBTf2//g== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Zhengchao Shao , Leon Romanovsky Subject: [net 02/15] net/mlx5: DR, fix memory leak in mlx5dr_cmd_create_reformat_ctx Date: Wed, 26 Jul 2023 14:31:53 -0700 Message-ID: <20230726213206.47022-3-saeed@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230726213206.47022-1-saeed@kernel.org> References: <20230726213206.47022-1-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zhengchao Shao when mlx5_cmd_exec failed in mlx5dr_cmd_create_reformat_ctx, the memory pointed by 'in' is not released, which will cause memory leak. Move memory release after mlx5_cmd_exec. Fixes: 1d9186476e12 ("net/mlx5: DR, Add direct rule command utilities") Signed-off-by: Zhengchao Shao Reviewed-by: Leon Romanovsky Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/steering/dr_cmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_cmd.c index 7491911ebcb5..8c2a34a0d6be 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_cmd.c @@ -564,11 +564,12 @@ int mlx5dr_cmd_create_reformat_ctx(struct mlx5_core_dev *mdev, err = mlx5_cmd_exec(mdev, in, inlen, out, sizeof(out)); if (err) - return err; + goto err_free_in; *reformat_id = MLX5_GET(alloc_packet_reformat_context_out, out, packet_reformat_id); - kvfree(in); +err_free_in: + kvfree(in); return err; } -- 2.41.0