From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 124DB18045 for ; Wed, 26 Jul 2023 21:32:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9D9AC433C7; Wed, 26 Jul 2023 21:32:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690407131; bh=Jipv8kNRgo3yBMh8Ls+LiUo4PYRyWDjEoYvF5+uS7jk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FMB1fqW0Te9oQ77cVcyKKu8XBbPV2Bl1POblYKKvMRhK+W7VcuR8OWo2GYVHSeXG+ PUOa2Mung7u+tFdoxDPqXjVeYUgPMpv+Xg4DUsKvGFZuHzrzqsyJqsJ3Dz00O+MLrv 2OZ4CgHj3jwBTKN8KJBlkiUubwge5XBNL/j93+CNRxvKVoSI0a1fcOvzUSrx11bSQM OF1kXPgghRpU6UalZHmvraxgfRok17hRxbDTI4uFj07MdDrFlxciujsX4r0jIlVCs8 JapelQ3Lhuu27jux4SyCMEJTls8My0DsV8Bxx6eGfbSpiu6XjEtxsEpSjshmof3te8 Tcb3UeuF3BC9w== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Zhengchao Shao , Simon Horman Subject: [net 03/15] net/mlx5: fix potential memory leak in mlx5e_init_rep_rx Date: Wed, 26 Jul 2023 14:31:54 -0700 Message-ID: <20230726213206.47022-4-saeed@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230726213206.47022-1-saeed@kernel.org> References: <20230726213206.47022-1-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Zhengchao Shao The memory pointed to by the priv->rx_res pointer is not freed in the error path of mlx5e_init_rep_rx, which can lead to a memory leak. Fix by freeing the memory in the error path, thereby making the error path identical to mlx5e_cleanup_rep_rx(). Fixes: af8bbf730068 ("net/mlx5e: Convert mlx5e_flow_steering member of mlx5e_priv to pointer") Signed-off-by: Zhengchao Shao Reviewed-by: Simon Horman Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c index 152b62138450..0b265a3f9b76 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c @@ -1012,7 +1012,7 @@ static int mlx5e_init_rep_rx(struct mlx5e_priv *priv) err = mlx5e_open_drop_rq(priv, &priv->drop_rq); if (err) { mlx5_core_err(mdev, "open drop rq failed, %d\n", err); - return err; + goto err_rx_res_free; } err = mlx5e_rx_res_init(priv->rx_res, priv->mdev, 0, @@ -1046,6 +1046,7 @@ static int mlx5e_init_rep_rx(struct mlx5e_priv *priv) mlx5e_rx_res_destroy(priv->rx_res); err_close_drop_rq: mlx5e_close_drop_rq(&priv->drop_rq); +err_rx_res_free: mlx5e_rx_res_free(priv->rx_res); priv->rx_res = NULL; err_free_fs: -- 2.41.0