From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D69BE18057 for ; Wed, 26 Jul 2023 21:32:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4AEDC43391; Wed, 26 Jul 2023 21:32:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690407132; bh=e+NFzb/vGwyizi28fk2u1oGZ2xB+dm+cEO+r1x7fHDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eJevch76t8P8brrHorNjC34pHJw7Fslxiav9OKLiMbKWdcI7P2rpXVIw/qwcBuXZH zCQfGC+AsbxHOKrO8wBGZEA9kz7IL3Mmdas0uaWoqd+RTJ1qpMD6n1PZg268430dW9 xqa3z3JrspNCKCraqCfJ80iZPV1c40Rge+zQK8QeMaFZBLiAxYS3Ffk3vjh3GqPGOz d23P/mHvJd8/RqptXg+Cf6NMAg227/Ho1Nwqvk2I/XFZ0UYvxCuFV6jQ0JylHGBRr/ 2OzovZBYBmsAxadB04CTcsjGgxCwaKjHSapdq0lg2q2IdWZdWmNLUdsDkOt2FfGUQb IRGu+GxP7h+Rg== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Yuanjun Gong , Leon Romanovsky Subject: [net 04/15] net/mlx5e: fix return value check in mlx5e_ipsec_remove_trailer() Date: Wed, 26 Jul 2023 14:31:55 -0700 Message-ID: <20230726213206.47022-5-saeed@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230726213206.47022-1-saeed@kernel.org> References: <20230726213206.47022-1-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Yuanjun Gong mlx5e_ipsec_remove_trailer() should return an error code if function pskb_trim() returns an unexpected value. Fixes: 2ac9cfe78223 ("net/mlx5e: IPSec, Add Innova IPSec offload TX data path") Signed-off-by: Yuanjun Gong Reviewed-by: Leon Romanovsky Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c index eab5bc718771..8d995e304869 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_rxtx.c @@ -58,7 +58,9 @@ static int mlx5e_ipsec_remove_trailer(struct sk_buff *skb, struct xfrm_state *x) trailer_len = alen + plen + 2; - pskb_trim(skb, skb->len - trailer_len); + ret = pskb_trim(skb, skb->len - trailer_len); + if (unlikely(ret)) + return ret; if (skb->protocol == htons(ETH_P_IP)) { ipv4hdr->tot_len = htons(ntohs(ipv4hdr->tot_len) - trailer_len); ip_send_check(ipv4hdr); -- 2.41.0