From: Jakub Kicinski <kuba@kernel.org>
To: Chuck Lever <cel@kernel.org>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, kernel-tls-handshake@lists.linux.dev
Subject: Re: [PATCH net-next v2 1/7] net/tls: Move TLS protocol elements to a separate header
Date: Wed, 26 Jul 2023 21:36:16 -0700 [thread overview]
Message-ID: <20230726213616.25141508@kernel.org> (raw)
In-Reply-To: <169031734129.15386.4192319236812962393.stgit@oracle-102.nfsv4bat.org>
On Tue, 25 Jul 2023 16:35:51 -0400 Chuck Lever wrote:
> --- a/include/net/tls.h
> +++ b/include/net/tls.h
> @@ -45,6 +45,7 @@
>
> #include <net/net_namespace.h>
> #include <net/tcp.h>
> +#include <net/tls_prot.h>
I'd be tempted to push this only to places that need it:
net/tls/tls.h
net/sunrpc/svcsock.c
net/sunrpc/xprtsock.c
drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_io.c
to make rebuilds smaller. Bunch of ethernet drivers will get rebuilt
every time we touch this header, and they don't care about the proto
details.
But I'm probably overly sensitive to build times so up to you.
next prev parent reply other threads:[~2023-07-27 4:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 20:35 [PATCH net-next v2 0/7] In-kernel support for the TLS Alert protocol Chuck Lever
2023-07-25 20:35 ` [PATCH net-next v2 1/7] net/tls: Move TLS protocol elements to a separate header Chuck Lever
2023-07-27 4:36 ` Jakub Kicinski [this message]
2023-07-27 13:05 ` Chuck Lever III
2023-07-25 20:36 ` [PATCH net-next v2 2/7] net/tls: Add TLS Alert definitions Chuck Lever
2023-07-25 20:36 ` [PATCH net-next v2 3/7] net/handshake: Add API for sending TLS Closure alerts Chuck Lever
2023-07-27 4:38 ` Jakub Kicinski
2023-07-27 13:08 ` Chuck Lever III
2023-07-25 20:37 ` [PATCH net-next v2 4/7] SUNRPC: Send TLS Closure alerts before closing a TCP socket Chuck Lever
2023-07-25 20:37 ` [PATCH net-next v2 5/7] net/handshake: Add helpers for parsing incoming TLS Alerts Chuck Lever
2023-07-25 20:37 ` [PATCH net-next v2 6/7] SUNRPC: Use new helpers to handle " Chuck Lever
2023-07-25 20:38 ` [PATCH net-next v2 7/7] net/handshake: Trace events for TLS Alert helpers Chuck Lever
2023-07-27 4:40 ` [PATCH net-next v2 0/7] In-kernel support for the TLS Alert protocol Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726213616.25141508@kernel.org \
--to=kuba@kernel.org \
--cc=cel@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).