From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
leit@meta.com,
netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH net-next] netconsole: Enable compile time configuration
Date: Thu, 27 Jul 2023 09:46:40 -0700 [thread overview]
Message-ID: <20230727094640.09c17f48@kernel.org> (raw)
In-Reply-To: <20230727163132.745099-1-leitao@debian.org>
On Thu, 27 Jul 2023 09:31:32 -0700 Breno Leitao wrote:
> +config NETCONSOLE_EXTENDED_LOG
> + bool "Enable kernel extended message"
> + depends on NETCONSOLE
> + default n
> + help
> + Enable extended log support for netconsole. Log messages are
> + transmitted with extended metadata header in the following format
> + which is the same as /dev/kmsg.
> + See <file:Documentation/networking/netconsole.rst> for details.
> +
> +config NETCONSOLE_APPEND_RELEASE
> + bool "Enable kernel release version in the message"
We need to say the word "default" in a few places, to make it very
clear these are defaults.
I'll defer to others on whether this option makes sense, as I'm
probably too familiar with the problem you're solving to be impartial :S
Also the posting is pooped, the diff is listed twice.
Keep in mind the 24 grace period for netdev postings:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr
--
pw-bot: cr
next prev parent reply other threads:[~2023-07-27 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 16:31 [PATCH net-next] netconsole: Enable compile time configuration Breno Leitao
2023-07-27 16:46 ` Jakub Kicinski [this message]
2023-07-27 18:47 ` Benjamin Poirier
2023-07-28 10:49 ` Breno Leitao
2023-07-27 22:51 ` Randy Dunlap
2023-07-28 10:50 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727094640.09c17f48@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=leit@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).