netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joel Granados <j.granados@samsung.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Joerg Reuter <jreuter@yaina.de>,
	Ralf Baechle <ralf@linux-mips.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	<willy@infradead.org>, <keescook@chromium.org>,
	<josh@joshtriplett.org>, <linux-hams@vger.kernel.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 09/14] ax.25: Update to register_net_sysctl_sz
Date: Fri, 28 Jul 2023 09:35:36 +0200	[thread overview]
Message-ID: <20230728073536.egpe6to3s3pndi6r@localhost> (raw)
In-Reply-To: <ZMKQ2OuFy1deZktP@bombadil.infradead.org>

[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]

On Thu, Jul 27, 2023 at 08:44:24AM -0700, Luis Chamberlain wrote:
> On Thu, Jul 27, 2023 at 02:31:12PM +0200, Joel Granados wrote:
> > There are no deltas in this patch set. We start seeing the deltas when
> > we start removing with the next 6 chunks. I'll try to make that more
> > clear in the commit message.
> 
> Indeed, even if no deltas are created it is importan then to say that.
> If there are no deltas the "why" becomes more important. If the why is
> to make it easier to apply subsequent patches, that must be said. When
yes. The why for this patch set in particular is to make it easier to
apply the sentinel removal patches.

I think the difficulty for me comes from having two whys: 1. The one for
this patch set which is to make it easier to apply sentinel removal patches. And 2.
The one for the "big" patch (that actually removes the sentinels) which is to
reduce build time size and run time memory bloat.

> you iterate your new series try to review the patches as if you were not
> the person submitting them, and try to think of ways to make it easier
> for the patch reviewer to do less work. The less work and easier patch
> review is the better for them.
Ack. For all these commits I'll try to weave in the two Whys to make the
review process a bit easier.

> 
>   Luis

-- 

Joel Granados

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2023-07-28  7:35 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20230726140656eucas1p26cd9da21663d25b51dda75258aaa3b55@eucas1p2.samsung.com>
     [not found] ` <20230726140635.2059334-1-j.granados@samsung.com>
2023-07-26 14:06   ` [PATCH 05/14] sysctl: Add a size arg to __register_sysctl_table Joel Granados
2023-07-28 10:51     ` Simon Horman
2023-07-28 16:08       ` Joel Granados
2023-07-26 14:06   ` [PATCH 06/14] sysctl: Add size to register_sysctl Joel Granados
2023-07-26 17:58     ` Luis Chamberlain
2023-07-27 12:22       ` Joel Granados
2023-07-27 15:42         ` Luis Chamberlain
2023-07-28  7:41           ` Joel Granados
2023-07-26 14:06   ` [PATCH 08/14] sysctl: Add size to register_net_sysctl function Joel Granados
2023-07-26 14:06   ` [PATCH 09/14] ax.25: Update to register_net_sysctl_sz Joel Granados
2023-07-26 18:00     ` Luis Chamberlain
2023-07-27 12:31       ` Joel Granados
2023-07-27 15:44         ` Luis Chamberlain
2023-07-28  7:35           ` Joel Granados [this message]
2023-07-28 18:16             ` Luis Chamberlain
2023-07-31  7:09               ` Joel Granados
2023-07-27 15:38       ` Joel Granados
2023-07-27 15:50         ` Luis Chamberlain
2023-07-26 14:06   ` [PATCH 10/14] netfilter: " Joel Granados
2023-07-26 18:01     ` Luis Chamberlain
2023-07-26 14:06   ` [PATCH 11/14] networking: " Joel Granados
2023-07-26 18:05     ` Luis Chamberlain
2023-07-27  0:33       ` David Ahern
2023-07-27 12:33       ` Joel Granados
2023-07-28  7:08       ` Joel Granados
2023-07-26 14:06   ` [PATCH 12/14] vrf: " Joel Granados
2023-07-26 14:06   ` [PATCH 13/14] sysctl: SIZE_MAX->ARRAY_SIZE in register_net_sysctl Joel Granados
2023-07-26 18:15   ` [PATCH 00/14] sysctl: Add a size argument to register functions in sysctl Luis Chamberlain
2023-07-27 11:43     ` Joel Granados
2023-07-27 15:39       ` Luis Chamberlain
2023-07-28  7:04         ` Joel Granados

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230728073536.egpe6to3s3pndi6r@localhost \
    --to=j.granados@samsung.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=josh@joshtriplett.org \
    --cc=jreuter@yaina.de \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-hams@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ralf@linux-mips.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).