From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Yunsheng Lin <linyunsheng@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Larysa Zaremba <larysa.zaremba@intel.com>,
Alexander Duyck <alexanderduyck@fb.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
Simon Horman <simon.horman@corigine.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 5/9] page_pool: don't use driver-set flags field directly
Date: Fri, 28 Jul 2023 08:50:24 -0700 [thread overview]
Message-ID: <20230728085024.684970ba@kernel.org> (raw)
In-Reply-To: <6f8147ec-b8ad-3905-5279-16817ed6f5ae@intel.com>
On Fri, 28 Jul 2023 16:03:53 +0200 Alexander Lobakin wrote:
> And it doesn't look really natural to me to pass both driver-set params
> and driver-set flags as separate function arguments.
+1
next prev parent reply other threads:[~2023-07-28 15:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 14:43 [PATCH net-next 0/9] page_pool: a couple of assorted optimizations Alexander Lobakin
2023-07-27 14:43 ` [PATCH net-next 1/9] page_pool: split types and declarations from page_pool.h Alexander Lobakin
2023-07-28 11:58 ` Yunsheng Lin
2023-07-28 13:55 ` Alexander Lobakin
2023-07-27 14:43 ` [PATCH net-next 2/9] net: skbuff: don't include <net/page_pool/types.h> to <linux/skbuff.h> Alexander Lobakin
2023-07-28 12:02 ` Yunsheng Lin
2023-07-28 13:58 ` Alexander Lobakin
2023-07-29 11:40 ` Yunsheng Lin
2023-08-01 13:25 ` Alexander Lobakin
2023-07-27 14:43 ` [PATCH net-next 3/9] page_pool: place frag_* fields in one cacheline Alexander Lobakin
2023-07-27 14:43 ` [PATCH net-next 4/9] page_pool: shrink &page_pool_params a tiny bit Alexander Lobakin
2023-07-27 14:43 ` [PATCH net-next 5/9] page_pool: don't use driver-set flags field directly Alexander Lobakin
2023-07-28 12:36 ` Yunsheng Lin
2023-07-28 14:03 ` Alexander Lobakin
2023-07-28 15:50 ` Jakub Kicinski [this message]
2023-07-29 11:40 ` Yunsheng Lin
2023-08-01 13:36 ` Alexander Lobakin
2023-08-02 11:36 ` Yunsheng Lin
2023-08-02 21:29 ` Jakub Kicinski
2023-08-03 14:56 ` Alexander Lobakin
2023-08-03 16:00 ` Jakub Kicinski
2023-08-03 16:07 ` Alexander Lobakin
2023-08-03 16:40 ` Jakub Kicinski
2023-08-03 16:42 ` Alexander Lobakin
2023-07-27 14:43 ` [PATCH net-next 6/9] page_pool: avoid calling no-op externals when possible Alexander Lobakin
2023-07-28 12:39 ` Yunsheng Lin
2023-07-28 14:14 ` Alexander Lobakin
2023-07-29 12:46 ` Yunsheng Lin
2023-08-01 13:42 ` Alexander Lobakin
2023-08-02 11:37 ` Yunsheng Lin
2023-08-02 15:49 ` Alexander Lobakin
2023-07-27 14:43 ` [PATCH net-next 7/9] net: skbuff: avoid accessing page_pool if !napi_safe when returning page Alexander Lobakin
2023-07-27 14:43 ` [PATCH net-next 8/9] page_pool: add a lockdep check for recycling in hardirq Alexander Lobakin
2023-07-27 14:43 ` [PATCH net-next 9/9] net: skbuff: always try to recycle PP pages directly when in softirq Alexander Lobakin
2023-07-28 9:32 ` Jesper Dangaard Brouer
2023-07-28 13:50 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728085024.684970ba@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).