[RESEND PATCH v2] selftests:connector: Fix input argument error paths to skip

[RESEND PATCH v2] selftests:connector: Fix input argument error paths to skip

[Shuah Khan]

Fix input argument parsing paths to skip from their error legs.
This fix helps to avoid false test failure reports without running
the test.

Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
---
v2: Removed root check based on Anjali's review comments.
Add netdev to RESEND

 tools/testing/selftests/connector/proc_filter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/testing/selftests/connector/proc_filter.c
index 4fe8c6763fd8..4a825b997666 100644
--- a/tools/testing/selftests/connector/proc_filter.c
+++ b/tools/testing/selftests/connector/proc_filter.c
@@ -248,7 +248,7 @@ int main(int argc, char *argv[])
 
 	if (argc > 2) {
 		printf("Expected 0(assume no-filter) or 1 argument(-f)\n");
-		exit(1);
+		exit(KSFT_SKIP);
 	}
 
 	if (argc == 2) {
@@ -256,7 +256,7 @@ int main(int argc, char *argv[])
 			filter = 1;
 		} else {
 			printf("Valid option : -f (for filter feature)\n");
-			exit(1);
+			exit(KSFT_SKIP);
 		}
 	}
 
-- 
2.39.2

Re: [RESEND PATCH v2] selftests:connector: Fix input argument error paths to skip

[Shuah Khan]

On 7/28/23 18:24, Shuah Khan wrote:
> Fix input argument parsing paths to skip from their error legs.
> This fix helps to avoid false test failure reports without running
> the test.
> 
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
> v2: Removed root check based on Anjali's review comments.
> Add netdev to RESEND
> 
>   tools/testing/selftests/connector/proc_filter.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/testing/selftests/connector/proc_filter.c
> index 4fe8c6763fd8..4a825b997666 100644
> --- a/tools/testing/selftests/connector/proc_filter.c
> +++ b/tools/testing/selftests/connector/proc_filter.c
> @@ -248,7 +248,7 @@ int main(int argc, char *argv[])
>   
>   	if (argc > 2) {
>   		printf("Expected 0(assume no-filter) or 1 argument(-f)\n");
> -		exit(1);
> +		exit(KSFT_SKIP);
>   	}
>   
>   	if (argc == 2) {
> @@ -256,7 +256,7 @@ int main(int argc, char *argv[])
>   			filter = 1;
>   		} else {
>   			printf("Valid option : -f (for filter feature)\n");
> -			exit(1);
> +			exit(KSFT_SKIP);
>   		}
>   	}
>   

Hi Jakub,

I sent v2 for patch 3 in the series. Do you want me to send the
entire series again with this revised 3rd patch.

thanks,
-- Shuah

Re: [RESEND PATCH v2] selftests:connector: Fix input argument error paths to skip

[Jakub Kicinski]

On Mon, 31 Jul 2023 14:23:45 -0600 Shuah Khan wrote:
> I sent v2 for patch 3 in the series. Do you want me to send the
> entire series again with this revised 3rd patch.

I think it's all good. The build bot couldn't parse the partial series
but the patches are pretty trivial, so low risk of breakage.

Anjali, it would be good to get your Review / Ack tag on this patch,
since you're the author.

Re: [RESEND PATCH v2] selftests:connector: Fix input argument error paths to skip

[Anjali Kulkarni]

> On Jul 31, 2023, at 2:07 PM, Jakub Kicinski <kuba@kernel.org> wrote:
> 
> On Mon, 31 Jul 2023 14:23:45 -0600 Shuah Khan wrote:
>> I sent v2 for patch 3 in the series. Do you want me to send the
>> entire series again with this revised 3rd patch.
> 
> I think it's all good. The build bot couldn't parse the partial series
> but the patches are pretty trivial, so low risk of breakage.
> 
> Anjali, it would be good to get your Review / Ack tag on this patch,
> since you're the author.

Yes done.
Anjali

Re: [RESEND PATCH v2] selftests:connector: Fix input argument error paths to skip

[Anjali Kulkarni]

> On Jul 28, 2023, at 5:24 PM, Shuah Khan <skhan@linuxfoundation.org> wrote:
> 
> Fix input argument parsing paths to skip from their error legs.
> This fix helps to avoid false test failure reports without running
> the test.
> 
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

Reviewed-by: Anjali Kulkarni <anjali.k.kulkarni@oracle.com>

> ---
> v2: Removed root check based on Anjali's review comments.
> Add netdev to RESEND
> 
> tools/testing/selftests/connector/proc_filter.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/connector/proc_filter.c b/tools/testing/selftests/connector/proc_filter.c
> index 4fe8c6763fd8..4a825b997666 100644
> --- a/tools/testing/selftests/connector/proc_filter.c
> +++ b/tools/testing/selftests/connector/proc_filter.c
> @@ -248,7 +248,7 @@ int main(int argc, char *argv[])
> 
> 	if (argc > 2) {
> 		printf("Expected 0(assume no-filter) or 1 argument(-f)\n");
> -		exit(1);
> +		exit(KSFT_SKIP);
> 	}
> 
> 	if (argc == 2) {
> @@ -256,7 +256,7 @@ int main(int argc, char *argv[])
> 			filter = 1;
> 		} else {
> 			printf("Valid option : -f (for filter feature)\n");
> -			exit(1);
> +			exit(KSFT_SKIP);
> 		}
> 	}
> 
> -- 
> 2.39.2
> 

Re: [RESEND PATCH v2] selftests:connector: Fix input argument error paths to skip

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 28 Jul 2023 18:24:03 -0600 you wrote:
> Fix input argument parsing paths to skip from their error legs.
> This fix helps to avoid false test failure reports without running
> the test.
> 
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
> v2: Removed root check based on Anjali's review comments.
> Add netdev to RESEND
> 
> [...]

Here is the summary with links:
  - [RESEND,v2] selftests:connector: Fix input argument error paths to skip
    https://git.kernel.org/netdev/net-next/c/04786c0659db

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html