From: Leon Romanovsky <leon@kernel.org>
To: Atul Raut <rauji.raut@gmail.com>
Cc: avem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org,
pabeni@redhat.com, rafal@milecki.pl,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] net/macmace: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
Date: Mon, 31 Jul 2023 10:38:01 +0300 [thread overview]
Message-ID: <20230731073801.GA87829@unreal> (raw)
In-Reply-To: <20230730231442.15003-1-rauji.raut@gmail.com>
On Sun, Jul 30, 2023 at 04:14:42PM -0700, Atul Raut wrote:
> Since zero-length arrays are deprecated, we are replacing
> them with C99 flexible-array members. As a result, instead
> of declaring a zero-length array, use the new
> DECLARE_FLEX_ARRAY() helper macro.
>
> This fixes warnings such as:
> ./drivers/net/ethernet/apple/macmace.c:80:4-8: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
>
> Signed-off-by: Atul Raut <rauji.raut@gmail.com>
> ---
> drivers/net/ethernet/apple/macmace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/apple/macmace.c b/drivers/net/ethernet/apple/macmace.c
> index 8fcaf1639920..8775c3234e91 100644
> --- a/drivers/net/ethernet/apple/macmace.c
> +++ b/drivers/net/ethernet/apple/macmace.c
> @@ -77,7 +77,7 @@ struct mace_frame {
> u8 pad4;
> u32 pad5;
> u32 pad6;
> - u8 data[1];
> + DECLARE_FLEX_ARRAY(u8, data);
But data[1] is not zero-length array.
> /* And frame continues.. */
> };
>
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2023-07-31 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 23:14 [PATCH] net/macmace: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Atul Raut
2023-07-31 7:38 ` Leon Romanovsky [this message]
2023-08-01 14:09 ` Larysa Zaremba
2023-08-01 21:51 ` Jakub Kicinski
2023-08-01 22:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731073801.GA87829@unreal \
--to=leon@kernel.org \
--cc=avem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal@milecki.pl \
--cc=rauji.raut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).