From: Jakub Kicinski <kuba@kernel.org>
To: "Limonciello, Mario" <mario.limonciello@amd.com>
Cc: hayeswang@realtek.com, edumazet@google.com,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, davem@davemloft.net,
linux-usb@vger.kernel.org, pabeni@redhat.com,
Paul Menzel <pmenzel@molgen.mpg.de>
Subject: Re: Error 'netif_napi_add_weight() called with weight 256'
Date: Mon, 31 Jul 2023 11:13:30 -0700 [thread overview]
Message-ID: <20230731111330.5211e637@kernel.org> (raw)
In-Reply-To: <0bfd445a-81f7-f702-08b0-bd5a72095e49@amd.com>
On Mon, 31 Jul 2023 11:02:40 -0500 Limonciello, Mario wrote:
> Hi,
>
> I noticed today with 6.5-rc4 and also on 6.1.42 that I'm getting an
> error from an r8152 based dongle (Framework ethernet expansion card).
>
> netif_napi_add_weight() called with weight 256
>
> It seems that this message is likely introduced by
> 8ded532cd1cbe ("r8152: switch to netif_napi_add_weight()")
>
> which if the card has support_2500full set will program the value to 256:
>
> netif_napi_add_weight(netdev, &tp->napi, r8152_poll,
> tp->support_2500full ? 256 : 64);
>
> It's err level from
> 82dc3c63c692b ("net: introduce NAPI_POLL_WEIGHT")
>
> Why is this considered an error but the driver uses the bigger value?
> Should it be downgraded to a warning?
Could you double check that the warning wasn't there before? The code
added by commit 195aae321c82 ("r8152: support new chips") in 5.13 looks
very much equivalent.
The custom weight is probably due to a misunderstanding. We have 200G
adapters using the standard weight of 64, IDK why 2.5G adapter would
need anything special.
next prev parent reply other threads:[~2023-07-31 18:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 16:02 Error 'netif_napi_add_weight() called with weight 256' Limonciello, Mario
2023-07-31 18:13 ` Jakub Kicinski [this message]
2023-07-31 18:23 ` Limonciello, Mario
2023-07-31 20:47 ` Stephen Hemminger
2023-08-07 9:57 ` Hayes Wang
2023-08-07 16:37 ` Jakub Kicinski
2023-08-09 13:11 ` Hayes Wang
2023-08-09 18:37 ` Jakub Kicinski
2023-08-14 7:07 ` Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731111330.5211e637@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).