From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A82257E for ; Tue, 1 Aug 2023 02:53:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2D79C433C7; Tue, 1 Aug 2023 02:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690858380; bh=XcSi2fRJmzOTE7kbjFWduXKD2IOr2CcrRDOP0d+XB3U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ermuXP4TzbEIoP6HVCvunAJRX6wX39KTyEc/JSZDVZ0IDn0FuzR1R9e05X4pAw9Gi 04QSRn/ikxukC5fqya9UhIgopkmXR6EreQieXZ1LEgWQHGWHTf4kgQmpHxn7Fk2Qlp zz0dl/cqnTygEo2ouoUUBbsPm1szil0aKaUdHT5lt7+VaMIH52Krj5L0laW99SUfji rhSaieTxKTV5P40aU2ROlYIIDOz/YSnZoZPudGCOZEToffKpN2Qy7xaBdAw7feJM9y Nf4UjAw5dDv/rXxK/6FocwPvR8/REuer9AcBWdeV5FXjJH1MxuJiVkisWeqzMISwtu b0kSixTNgUiNA== Date: Mon, 31 Jul 2023 19:52:58 -0700 From: Jakub Kicinski To: Breno Leitao Cc: rdunlap@infradead.org, benjamin.poirier@gmail.com, "David S. Miller" , Eric Dumazet , Paolo Abeni , leit@meta.com, netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH net-next v2] netconsole: Enable compile time configuration Message-ID: <20230731195258.16b3a53d@kernel.org> In-Reply-To: <20230731083542.3665886-1-leitao@debian.org> References: <20230731083542.3665886-1-leitao@debian.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 31 Jul 2023 01:35:41 -0700 Breno Leitao wrote: > +config NETCONSOLE_EXTENDED_LOG > + bool "Set kernel extended message as default" > + depends on NETCONSOLE > + default n > + help > + Set extended log support for netconsole message. If this option is > + set, log messages are transmitted with extended metadata header in a > + format similar to /dev/kmsg. See > + for details. > + > +config NETCONSOLE_PREPEND_RELEASE > + bool "Prepend kernel release version in the message" ... by default > + depends on NETCONSOLE_EXTENDED_LOG > + default n > + help > + Set kernel release to be prepended to each netconsole message by > + default. If this option is set, the kernel release is prepended into > + the first field of every netconsole message, so, the netconsole > + server/peer can easily identify what kernel release is logging each > + message. See for > + details. I had to look at the code to see what this does, exactly. I think you either need to make similar changes to make_netconsole_target() so that instances created via sysfs have the same default. Or rewrite the help message to talk about forcing kernel command line arguments, rather than setting defaults. -- pw-bot: cr