From: Liang Chen <liangchen.linux@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linyunsheng@huawei.com
Cc: hawk@kernel.org, ilias.apalodimas@linaro.org,
daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org,
liangchen.linux@gmail.com
Subject: [RFC PATCH net-next v2 1/2] net: veth: Page pool creation error handling for existing pools only
Date: Tue, 1 Aug 2023 14:19:31 +0800 [thread overview]
Message-ID: <20230801061932.10335-1-liangchen.linux@gmail.com> (raw)
The failure handling procedure destroys page pools for all queues,
including those that haven't had their page pool created yet. this patch
introduces necessary adjustments to prevent potential risks and
inconsistency with the error handling behavior.
Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
---
drivers/net/veth.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index 614f3e3efab0..509e901da41d 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -1081,8 +1081,9 @@ static int __veth_napi_enable_range(struct net_device *dev, int start, int end)
err_xdp_ring:
for (i--; i >= start; i--)
ptr_ring_cleanup(&priv->rq[i].xdp_ring, veth_ptr_free);
+ i = end;
err_page_pool:
- for (i = start; i < end; i++) {
+ for (i--; i >= start; i--) {
page_pool_destroy(priv->rq[i].page_pool);
priv->rq[i].page_pool = NULL;
}
--
2.40.1
next reply other threads:[~2023-08-01 6:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 6:19 Liang Chen [this message]
2023-08-01 6:19 ` [RFC PATCH net-next v2 2/2] net: veth: Improving page pool pages recycling Liang Chen
2023-08-02 12:32 ` Yunsheng Lin
2023-08-07 12:20 ` Liang Chen
2023-08-08 11:16 ` Yunsheng Lin
2023-08-09 10:01 ` Liang Chen
2023-08-09 12:35 ` Yunsheng Lin
2023-08-12 1:52 ` Liang Chen
2023-08-11 18:16 ` Jesper Dangaard Brouer
2023-08-12 2:02 ` Liang Chen
2023-08-01 12:18 ` [RFC PATCH net-next v2 1/2] net: veth: Page pool creation error handling for existing pools only Simon Horman
2023-08-11 11:56 ` Liang Chen
2023-08-02 8:56 ` Jesper Dangaard Brouer
2023-08-11 12:02 ` Liang Chen
2023-08-11 16:35 ` Jesper Dangaard Brouer
2023-08-12 2:16 ` Liang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801061932.10335-1-liangchen.linux@gmail.com \
--to=liangchen.linux@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kuba@kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).