From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Lin Ma <linma@zju.edu.cn>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
fw@strlen.de, yang.lee@linux.alibaba.com, jgg@ziepe.ca,
markzhang@nvidia.com, phaddad@nvidia.com, yuancan@huawei.com,
ohartoov@nvidia.com, chenzhongjin@huawei.com, aharonl@nvidia.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v1 1/2] netlink: let len field used to parse type-not-care nested attrs
Date: Tue, 1 Aug 2023 11:11:17 +0300 [thread overview]
Message-ID: <20230801081117.GA53714@unreal> (raw)
In-Reply-To: <20230731120326.6bdd5bf9@kernel.org>
On Mon, Jul 31, 2023 at 12:03:26PM -0700, Jakub Kicinski wrote:
> On Mon, 31 Jul 2023 20:12:47 +0800 Lin Ma wrote:
> > In short, the very direct idea to fix such lengh-check-forgotten bug is
> > add nla_len() checks like
> >
> > if (nla_len(nla) < SOME_LEN)
> > return -EINVAL;
> >
> > However, this is tedious and just like Leon said: add another layer of
> > cabal knowledge. The better solution should leverage the nla_policy and
> > discard nlattr whose length is invalid when doing parsing. That is, we
> > should defined a nested_policy for the X above like
>
> Hard no. Putting array index into attr type is an advanced case and the
> parsing code has to be able to deal with low level netlink details.
Jakub,
IMHO, you are lowering too much the separation line between simple vs.
advanced use cases.
I had no idea that my use-case of passing nested netlink array is counted
as advanced usage.
Thanks
next prev parent reply other threads:[~2023-08-01 8:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 12:12 [PATCH net v1 1/2] netlink: let len field used to parse type-not-care nested attrs Lin Ma
2023-07-31 19:03 ` Jakub Kicinski
2023-08-01 2:00 ` Lin Ma
2023-08-01 2:31 ` Jakub Kicinski
2023-08-01 2:40 ` Lin Ma
2023-08-01 8:11 ` Leon Romanovsky [this message]
2023-08-01 17:57 ` Jakub Kicinski
2023-08-01 19:49 ` Leon Romanovsky
2023-08-02 0:26 ` Lin Ma
2023-08-02 0:53 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801081117.GA53714@unreal \
--to=leon@kernel.org \
--cc=aharonl@nvidia.com \
--cc=chenzhongjin@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=linma@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=ohartoov@nvidia.com \
--cc=pabeni@redhat.com \
--cc=phaddad@nvidia.com \
--cc=yang.lee@linux.alibaba.com \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).