From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
edumazet@google.com, moshe@nvidia.com, saeedm@nvidia.com,
idosch@nvidia.com, petrm@nvidia.com
Subject: Re: [patch net-next 4/8] devlink: add split ops generated according to spec
Date: Tue, 1 Aug 2023 11:56:55 -0700 [thread overview]
Message-ID: <20230801115655.296b3d28@kernel.org> (raw)
In-Reply-To: <20230801141907.816280-5-jiri@resnulli.us>
On Tue, 1 Aug 2023 16:19:03 +0200 Jiri Pirko wrote:
> Improve the existing devlink spec in order to serve as a source fot
s/fot/for/
> generation of valid devlink split ops for the existing commands.
> Add the generated sources.
> +/* DEVLINK_CMD_GET - do */
> +const struct nla_policy devlink_get_nl_policy[DEVLINK_ATTR_DEV_NAME + 1] = {
> + [DEVLINK_ATTR_BUS_NAME] = { .type = NLA_NUL_STRING, },
> + [DEVLINK_ATTR_DEV_NAME] = { .type = NLA_NUL_STRING, },
> +};
What's the impact of narrowing down the policies? Could you describe it
in the commit message?
next prev parent reply other threads:[~2023-08-01 18:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 14:18 [patch net-next 0/8] devlink: use spec to generate split ops Jiri Pirko
2023-08-01 14:19 ` [patch net-next 1/8] ynl-gen-c.py: fix rendering of validate field Jiri Pirko
2023-08-01 18:25 ` Jakub Kicinski
2023-08-02 6:41 ` Jiri Pirko
2023-08-01 14:19 ` [patch net-next 2/8] ynl-gen-c.py: allow directional model for kernel mode Jiri Pirko
2023-08-01 18:27 ` Jakub Kicinski
2023-08-02 6:42 ` Jiri Pirko
2023-08-02 8:51 ` Jiri Pirko
2023-08-01 14:19 ` [patch net-next 3/8] devlink: rename devlink_nl_ops to devlink_nl_small_ops Jiri Pirko
2023-08-01 14:19 ` [patch net-next 4/8] devlink: add split ops generated according to spec Jiri Pirko
2023-08-01 18:56 ` Jakub Kicinski [this message]
2023-08-02 6:44 ` Jiri Pirko
2023-08-01 14:19 ` [patch net-next 5/8] devlink: include the generated netlink header Jiri Pirko
2023-08-01 14:19 ` [patch net-next 6/8] devlink: rename couple of doit netlink callbacks to match generated names Jiri Pirko
2023-08-01 14:19 ` [patch net-next 7/8] devlink: introduce couple of dumpit callback for split ops Jiri Pirko
2023-08-01 14:19 ` [patch net-next 8/8] devlink: use generated split ops and remove duplicated commands from small ops Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801115655.296b3d28@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).