From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 674A125170; Tue, 1 Aug 2023 19:58:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7976AC433C7; Tue, 1 Aug 2023 19:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690919910; bh=79BwIOnM6SioCje3neXfEamXafGIUojs9GGzwDzIaT8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WaG0UuuiBslQIwwDoxSGmwylSNwUwUH7DIQ7eAy76ZMwNQxm6uzQTZe+DpR8IvAQD AR9sF34c6pu020pThaegFYojP886SrOpKscmfRnTNlEgNYWd06/PU127Un7orzG1/E 9rUKbhIJY4SvTChDop2NC6sJMRkZgC9FxkLKSBCJ5AX8gdvgUcXJEF/V5ZaRjvw4ws g4igCCOm2Ui3wG63wvnwlKi2DoXv7gVow1xbUTW25ecmVHjRgzWHzoVjMTgMGAYnGS yrqItcGmOO8B2dQEyoty0KKnJhLztUcShDR3TUA3S9ggYOAW7cy5RY8WUi7dlpa5+q jNZZJhtmtcNHQ== Date: Tue, 1 Aug 2023 12:58:28 -0700 From: Jakub Kicinski To: Shenwei Wang Cc: Marc Kleine-Budde , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Maxime Coquelin , Shawn Guo , Sascha Hauer , Neil Armstrong , Kevin Hilman , Vinod Koul , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jose Abreu , "imx@lists.linux.dev" , Simon Horman , Alexandre Torgue , Giuseppe Cavallaro , Nobuhiro Iwamatsu , Fabio Estevam , "linux-stm32@st-md-mailman.stormreply.com" , Jerome Brunet , Bartosz Golaszewski , Wong Vee Khee , dl-linux-imx , Andrew Halaney , Bhupesh Sharma , Martin Blumenstingl , Revanth Kumar Uppala , Jochen Henneberg , "linux-amlogic@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pengutronix Kernel Team Subject: Re: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed Message-ID: <20230801125828.209c5e88@kernel.org> In-Reply-To: References: <20230731161929.2341584-1-shenwei.wang@nxp.com> <20230731161929.2341584-2-shenwei.wang@nxp.com> <20230801-portside-prepaid-513f1f39f245-mkl@pengutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 1 Aug 2023 18:43:52 +0000 Shenwei Wang wrote: > Subject: RE: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed Looks like new platform enablement, the correct tree to target this at is net-next (i.e. [PATCH net-next]). > > -----Original Message----- > > From: Marc Kleine-Budde > > Sent: Tuesday, August 1, 2023 1:37 AM > > To: Shenwei Wang > > Cc: Russell King ; David S. Miller > > ; Eric Dumazet ; Jakub > > Kicinski ; Paolo Abeni ; Maxime > > Coquelin ; Shawn Guo ; > > Sascha Hauer ; Neil Armstrong > > ; Kevin Hilman ; Vinod > > Koul ; Chen-Yu Tsai ; Jernej Skrabec > > ; Samuel Holland ; Jose > > Abreu ; imx@lists.linux.dev; Simon Horman > > ; Alexandre Torgue > > ; Giuseppe Cavallaro > > ; Nobuhiro Iwamatsu > > ; Fabio Estevam ; > > linux-stm32@st-md-mailman.stormreply.com; Jerome Brunet > > ; Bartosz Golaszewski > > ; Wong Vee Khee ; dl- > > linux-imx ; Andrew Halaney ; > > Bhupesh Sharma ; Martin Blumenstingl > > ; Revanth Kumar Uppala > > ; Jochen Henneberg ; > > linux-amlogic@lists.infradead.org; linux-arm-kernel@lists.infradead.org; > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Pengutronix Kernel > > Team > > Subject: [EXT] Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter > > for fix_mac_speed Why is this quote included? Please get a sane email client. > > On 31.07.2023 11:19:28, Shenwei Wang wrote: > > > A mode parameter has been added to the callback function of > > > fix_mac_speed to indicate the physical layer type. > > > > > > The mode can be one the following: > > > MLO_AN_PHY - Conventional PHY > > > MLO_AN_FIXED - Fixed-link mode > > > MLO_AN_INBAND - In-band protocol > > > > > > Also use short version of 'uint' to replace the 'unsigned int' in the > > > function definitions. > > > > There are not many users of 'uint' in the kernel and it's not used in the stmmac > > driver so far. From my point of view I would not introduce it and stick to the > > standard 'unsigned int'. > > Using 'uint' makes the code look cleaner because adding one extra > parameter may cause some function declarations to span multiple > lines. This change keeps function declarations compact on a single > line. Marc is right. Just do it.