From: Jakub Kicinski <kuba@kernel.org>
To: Wei Fang <wei.fang@nxp.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
shenwei.wang@nxp.com, xiaoning.wang@nxp.com, ast@kernel.org,
daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com,
netdev@vger.kernel.org, linux-imx@nxp.com,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH V3 net-next] net: fec: add XDP_TX feature support
Date: Tue, 1 Aug 2023 14:57:23 -0700 [thread overview]
Message-ID: <20230801145723.7ddc2dba@kernel.org> (raw)
In-Reply-To: <20230731060025.3117343-1-wei.fang@nxp.com>
On Mon, 31 Jul 2023 14:00:25 +0800 Wei Fang wrote:
> case XDP_TX:
> + err = fec_enet_xdp_tx_xmit(fep->netdev, xdp);
> + if (err) {
> + ret = FEC_ENET_XDP_CONSUMED;
> + page = virt_to_head_page(xdp->data);
> + page_pool_put_page(rxq->page_pool, page, sync, true);
The error path should call trace_xdp_exception().
--
pw-bot: cr
next prev parent reply other threads:[~2023-08-01 21:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 6:00 [PATCH V3 net-next] net: fec: add XDP_TX feature support Wei Fang
2023-08-01 15:34 ` Larysa Zaremba
2023-08-01 19:51 ` Jakub Kicinski
2023-08-02 11:46 ` Larysa Zaremba
2023-08-01 21:57 ` Jakub Kicinski [this message]
2023-08-02 2:43 ` Wei Fang
2023-08-02 9:26 ` Jesper Dangaard Brouer
2023-08-02 9:59 ` Wei Fang
2023-08-02 12:34 ` Jesper Dangaard Brouer
2023-08-02 12:33 ` Wei Fang
2023-08-04 12:09 ` Jesper Dangaard Brouer
2023-08-07 8:41 ` Wei Fang
2023-08-02 17:47 ` Jakub Kicinski
2023-08-03 3:58 ` Wei Fang
2023-08-03 7:36 ` Jesper Dangaard Brouer
2023-08-03 11:18 ` Wei Fang
2023-08-03 12:55 ` Jesper Dangaard Brouer
2023-08-04 3:06 ` Wei Fang
2023-08-04 12:36 ` Jesper Dangaard Brouer
2023-08-07 10:30 ` Wei Fang
2023-08-07 13:15 ` Jesper Dangaard Brouer
2023-08-08 5:02 ` Wei Fang
2023-08-08 11:33 ` Jesper Dangaard Brouer
2023-08-09 6:22 ` Wei Fang
2023-08-07 16:33 ` Jakub Kicinski
2023-08-08 0:19 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801145723.7ddc2dba@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).