From: Jakub Kicinski <kuba@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, hawk@kernel.org, ilias.apalodimas@linaro.org,
corbet@lwn.net, linux-doc@vger.kernel.org,
Michael Chan <michael.chan@broadcom.com>,
Lorenzo Bianconi <lorenzo@kernel.org>
Subject: Re: [PATCH net] docs: net: page_pool: document PP_FLAG_DMA_SYNC_DEV parameters
Date: Tue, 1 Aug 2023 15:10:12 -0700 [thread overview]
Message-ID: <20230801151012.3be47633@kernel.org> (raw)
In-Reply-To: <23be0fd9-9177-a8bd-e436-07f52e40e79b@infradead.org>
On Tue, 1 Aug 2023 14:58:48 -0700 Randy Dunlap wrote:
> > +If in doubt set ``offset`` to 0, ``max_len`` to ``PAGE_SIZE`` and
> > +pass -1 as ``dma_sync_size``. That combination of arguments is always
> > +correct.
>
> at the expense of more overhead?
Should be implied by the context, I hope, so no point stating it?
Thanks for all the other corrections, will fix in v2.
--
pw-bot: cr
prev parent reply other threads:[~2023-08-01 22:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 20:31 [PATCH net] docs: net: page_pool: document PP_FLAG_DMA_SYNC_DEV parameters Jakub Kicinski
2023-08-01 21:58 ` Randy Dunlap
2023-08-01 22:10 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801151012.3be47633@kernel.org \
--to=kuba@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).