From: Jakub Kicinski <kuba@kernel.org>
To: "Lin Ma" <linma@zju.edu.cn>
Cc: "Leon Romanovsky" <leon@kernel.org>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
fw@strlen.de, yang.lee@linux.alibaba.com, jgg@ziepe.ca,
markzhang@nvidia.com, phaddad@nvidia.com, yuancan@huawei.com,
ohartoov@nvidia.com, chenzhongjin@huawei.com, aharonl@nvidia.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v1 1/2] netlink: let len field used to parse type-not-care nested attrs
Date: Tue, 1 Aug 2023 17:53:38 -0700 [thread overview]
Message-ID: <20230801175338.74bc39c2@kernel.org> (raw)
In-Reply-To: <385b9766.f63d7.189b3a33c6b.Coremail.linma@zju.edu.cn>
On Wed, 2 Aug 2023 08:26:06 +0800 (GMT+08:00) Lin Ma wrote:
> This is true. Actually, those check missing codes are mostly old codes and
> modern netlink consumers will choose the general netlink interface which
> can automatically get attributes description from YAML and never need to
> do things like *manual parsing* anymore.
>
> However, according to my practice in auditing the code, I found there are
> some general netlink interface users confront other issues like choosing
> GENL_DONT_VALIDATE_STRICT without thinking or forgetting add a new
> nla_policy when introducing new attributes.
>
> To this end, I'm currently writing a simple documentation about Netlink
> interface best practices for the kernel developer (the newly coming docs
> are mostly about the user API part).
Keep in mind that even most of the genetlink stuff is pretty old
at this stage. ethtool is probably the first reasonably modern family.
But do send docs, we'll review and go from there :)
prev parent reply other threads:[~2023-08-02 0:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 12:12 [PATCH net v1 1/2] netlink: let len field used to parse type-not-care nested attrs Lin Ma
2023-07-31 19:03 ` Jakub Kicinski
2023-08-01 2:00 ` Lin Ma
2023-08-01 2:31 ` Jakub Kicinski
2023-08-01 2:40 ` Lin Ma
2023-08-01 8:11 ` Leon Romanovsky
2023-08-01 17:57 ` Jakub Kicinski
2023-08-01 19:49 ` Leon Romanovsky
2023-08-02 0:26 ` Lin Ma
2023-08-02 0:53 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801175338.74bc39c2@kernel.org \
--to=kuba@kernel.org \
--cc=aharonl@nvidia.com \
--cc=chenzhongjin@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linma@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markzhang@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=ohartoov@nvidia.com \
--cc=pabeni@redhat.com \
--cc=phaddad@nvidia.com \
--cc=yang.lee@linux.alibaba.com \
--cc=yuancan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).