From: Liang Chen <liangchen.linux@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com,
ilias.apalodimas@linaro.org, netdev@vger.kernel.org,
liangchen.linux@gmail.com
Subject: [PATCH net-next] xdp: Fixing skb->pp_recycle flag in generic XDP handling
Date: Wed, 2 Aug 2023 15:04:54 +0800 [thread overview]
Message-ID: <20230802070454.22534-1-liangchen.linux@gmail.com> (raw)
In the generic XDP processing flow, if an skb with a page pool page
(skb->pp_recycle == 1) fails to meet XDP packet requirements, it will
undergo head expansion and linearization of fragment data. As a result,
skb->head points to a reallocated buffer without any fragments. At this
point, the skb will not contain any page pool pages. However, the
skb->pp_recycle flag is still set to 1, which is inconsistent with the
actual situation. Although it doesn't seem to cause much real harm at the
moment(a little nagetive impact on skb_try_coalesce), to avoid potential
issues associated with using incorrect skb->pp_recycle information,
setting skb->pp_recycle to 0 to reflect the pp state of the skb.
Signed-off-by: Liang Chen <liangchen.linux@gmail.com>
---
net/core/dev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index 10e5a036c706..07baf72be7d7 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -4934,6 +4934,8 @@ static u32 netif_receive_generic_xdp(struct sk_buff *skb,
goto do_drop;
if (skb_linearize(skb))
goto do_drop;
+ if (skb->pp_recycle)
+ skb->pp_recycle = 0;
}
act = bpf_prog_run_generic_xdp(skb, xdp, xdp_prog);
--
2.40.1
next reply other threads:[~2023-08-02 7:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 7:04 Liang Chen [this message]
2023-08-02 17:09 ` [PATCH net-next] xdp: Fixing skb->pp_recycle flag in generic XDP handling Alexander Lobakin
2023-08-03 8:25 ` Liang Chen
2023-08-03 15:14 ` Alexander Lobakin
2023-08-07 12:49 ` Liang Chen
2023-08-02 18:37 ` Jakub Kicinski
2023-08-03 8:26 ` Liang Chen
2023-08-03 8:58 ` Ilias Apalodimas
2023-08-03 12:17 ` Liang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802070454.22534-1-liangchen.linux@gmail.com \
--to=liangchen.linux@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ilias.apalodimas@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).