From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Ioana Ciornei <ioana.ciornei@nxp.com>,
Antoine Tenart <atenart@kernel.org>,
Alexander Duyck <alexander.duyck@gmail.com>
Cc: netdev@vger.kernel.org
Subject: netif_set_xps_queue() before register_netdev(): correct from an API perspective?
Date: Wed, 2 Aug 2023 17:57:36 +0300 [thread overview]
Message-ID: <20230802145736.gp4bbudizpk7elk3@skbuf> (raw)
Hi,
When drivers/net/ethernet/freescale/dpaa2/ fails to probe (including -EPROBE_DEFER),
I see lots of these:
$ cat /sys/kernel/debug/kmemleak
unreferenced object 0xffff042845fbdac0 (size 64):
comm "kworker/u16:1", pid 56, jiffies 4294893690 (age 859.844s)
hex dump (first 32 bytes):
01 00 00 00 14 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 06 00 00 00 00 00 00 00 ................
backtrace:
[<ffffc754095a7dfc>] slab_post_alloc_hook+0xa4/0x330
[<ffffc754095a654c>] __kmem_cache_alloc_node+0x23c/0x308
[<ffffc7540952fec0>] __kmalloc_node+0xc0/0x240
[<ffffc7540a976934>] __netif_set_xps_queue+0x32c/0xa78
[<ffffc7540a9771e4>] netif_set_xps_queue+0x44/0x70
[<ffffc7540a1c3540>] update_xps+0xb0/0x158
[<ffffc7540a1c0290>] dpaa2_eth_probe+0xd10/0x1368
[<ffffc75409b1677c>] fsl_mc_driver_probe+0x2c/0x80
[<ffffc75409eb764c>] really_probe+0x13c/0x2f8
[<ffffc75409eb666c>] __driver_probe_device+0xac/0x140
[<ffffc75409eb7340>] driver_probe_device+0x48/0x218
[<ffffc75409eb71d8>] __device_attach_driver+0x128/0x158
[<ffffc75409eb33e4>] bus_for_each_drv+0x12c/0x160
[<ffffc75409eb63f4>] __device_attach+0xcc/0x1a0
[<ffffc75409eb64e8>] device_initial_probe+0x20/0x38
[<ffffc75409eb3620>] bus_probe_device+0xa0/0x118
I see that netif_set_xps_queue() allocates dev->xps_maps[], which is
eventually freed by reset_xps_maps() <- ... <- netif_reset_xps_queues_gt()
from a number of call sites, including from unregister_netdevice_many_notify().
This is nice, but dpaa2 (above) and emulex/benet/be_main.c call
netif_set_xps_queue() prior to registering the net device. So no
deregistration event will take place.
How is the memory supposed to be freed in this case?
next reply other threads:[~2023-08-02 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 14:57 Vladimir Oltean [this message]
2023-08-02 15:04 ` netif_set_xps_queue() before register_netdev(): correct from an API perspective? Alexander Duyck
2023-08-02 15:22 ` Vladimir Oltean
2023-08-02 16:42 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802145736.gp4bbudizpk7elk3@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=alexander.duyck@gmail.com \
--cc=atenart@kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox