From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Ratheesh Kannoth <rkannoth@marvell.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sgoutham@marvell.com>,
<gakula@marvell.com>, <sbhatta@marvell.com>, <hkelam@marvell.com>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>
Subject: Re: [PATCH net] octeontx2-pf: Set maximum queue size to 16K
Date: Wed, 2 Aug 2023 18:13:41 -0700 [thread overview]
Message-ID: <20230802181341.14cb2e4b@kernel.org> (raw)
In-Reply-To: <18fec8cd-fc91-736e-7c01-453a18f4e9c5@intel.com>
On Wed, 2 Aug 2023 18:11:35 +0200 Alexander Lobakin wrote:
> > - ring->rx_max_pending = Q_COUNT(Q_SIZE_MAX);
> > + ring->rx_max_pending = 16384; /* Page pool support on RX */
>
> This is very hardcodish. Why not limit the Page Pool size when creating
> instead? It's perfectly fine to have a queue with 64k descriptors and a
> Page Pool with only ("only" :D) 16k elements.
> Page Pool size affects only the size of the embedded ptr_ring, which is
> used for indirect (locking) recycling. I would even recommend to not go
> past 2k for PP sizes, it makes no sense and only consumes memory.
Should we make the page pool cap the size at 32k then, instead of
having drivers do the gymnastics? I don't see what else the driver
can do, other than cap :S
--
pw-bot: cr
next prev parent reply other threads:[~2023-08-03 1:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 10:52 [PATCH net] octeontx2-pf: Set maximum queue size to 16K Ratheesh Kannoth
2023-08-02 16:11 ` Alexander Lobakin
2023-08-03 1:13 ` Jakub Kicinski [this message]
2023-08-03 2:08 ` Ratheesh Kannoth
2023-08-03 15:07 ` Alexander Lobakin
2023-08-04 2:25 ` [EXT] " Ratheesh Kannoth
2023-08-04 14:43 ` Alexander Lobakin
2023-08-04 20:35 ` Jakub Kicinski
2023-08-07 2:51 ` Ratheesh Kannoth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802181341.14cb2e4b@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).