From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
kernel@pengutronix.de,
Markus Schneider-Pargmann <msp@baylibre.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH net-next 7/9] can: tcan4x5x: Add error messages in probe
Date: Thu, 3 Aug 2023 10:08:28 +0200 [thread overview]
Message-ID: <20230803080830.1386442-8-mkl@pengutronix.de> (raw)
In-Reply-To: <20230803080830.1386442-1-mkl@pengutronix.de>
From: Markus Schneider-Pargmann <msp@baylibre.com>
To be able to understand issues during probe easier, add error messages
if something fails.
Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Link: https://lore.kernel.org/all/20230728141923.162477-7-msp@baylibre.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/m_can/tcan4x5x-core.c | 29 +++++++++++++++++++++------
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/drivers/net/can/m_can/tcan4x5x-core.c b/drivers/net/can/m_can/tcan4x5x-core.c
index 2d329b4e4f52..8a4143809d33 100644
--- a/drivers/net/can/m_can/tcan4x5x-core.c
+++ b/drivers/net/can/m_can/tcan4x5x-core.c
@@ -402,6 +402,8 @@ static int tcan4x5x_can_probe(struct spi_device *spi)
/* Sanity check */
if (freq < 20000000 || freq > TCAN4X5X_EXT_CLK_DEF) {
+ dev_err(&spi->dev, "Clock frequency is out of supported range %d\n",
+ freq);
ret = -ERANGE;
goto out_m_can_class_free_dev;
}
@@ -420,16 +422,23 @@ static int tcan4x5x_can_probe(struct spi_device *spi)
/* Configure the SPI bus */
spi->bits_per_word = 8;
ret = spi_setup(spi);
- if (ret)
+ if (ret) {
+ dev_err(&spi->dev, "SPI setup failed %pe\n", ERR_PTR(ret));
goto out_m_can_class_free_dev;
+ }
ret = tcan4x5x_regmap_init(priv);
- if (ret)
+ if (ret) {
+ dev_err(&spi->dev, "regmap init failed %pe\n", ERR_PTR(ret));
goto out_m_can_class_free_dev;
+ }
ret = tcan4x5x_power_enable(priv->power, 1);
- if (ret)
+ if (ret) {
+ dev_err(&spi->dev, "Enabling regulator failed %pe\n",
+ ERR_PTR(ret));
goto out_m_can_class_free_dev;
+ }
version_info = tcan4x5x_find_version(priv);
if (IS_ERR(version_info)) {
@@ -438,16 +447,24 @@ static int tcan4x5x_can_probe(struct spi_device *spi)
}
ret = tcan4x5x_get_gpios(mcan_class, version_info);
- if (ret)
+ if (ret) {
+ dev_err(&spi->dev, "Getting gpios failed %pe\n", ERR_PTR(ret));
goto out_power;
+ }
ret = tcan4x5x_init(mcan_class);
- if (ret)
+ if (ret) {
+ dev_err(&spi->dev, "tcan initialization failed %pe\n",
+ ERR_PTR(ret));
goto out_power;
+ }
ret = m_can_class_register(mcan_class);
- if (ret)
+ if (ret) {
+ dev_err(&spi->dev, "Failed registering m_can device %pe\n",
+ ERR_PTR(ret));
goto out_power;
+ }
netdev_info(mcan_class->net, "TCAN4X5X successfully initialized.\n");
return 0;
--
2.40.1
next prev parent reply other threads:[~2023-08-03 8:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 8:08 [PATCH net-next 0/9] pull-request: can-next 2023-08-03 Marc Kleine-Budde
2023-08-03 8:08 ` [PATCH net-next 1/9] can: flexcan: fix the return value handle for platform_get_irq() Marc Kleine-Budde
2023-08-04 7:50 ` patchwork-bot+netdevbpf
2023-08-03 8:08 ` [PATCH net-next 2/9] dt-bindings: can: tcan4x5x: Add tcan4552 and tcan4553 variants Marc Kleine-Budde
2023-08-03 8:08 ` [PATCH net-next 3/9] can: tcan4x5x: Remove reserved register 0x814 from writable table Marc Kleine-Budde
2023-08-03 8:08 ` [PATCH net-next 4/9] can: tcan4x5x: Check size of mram configuration Marc Kleine-Budde
2023-08-03 8:08 ` [PATCH net-next 5/9] can: tcan4x5x: Rename ID registers to match datasheet Marc Kleine-Budde
2023-08-03 8:08 ` [PATCH net-next 6/9] can: tcan4x5x: Add support for tcan4552/4553 Marc Kleine-Budde
2023-08-03 8:08 ` Marc Kleine-Budde [this message]
2023-08-03 8:08 ` [PATCH net-next 8/9] can: c_can: Do not check for 0 return after calling platform_get_irq() Marc Kleine-Budde
2023-08-03 8:08 ` [PATCH net-next 9/9] can: esd_usb: Add support for esd CAN-USB/3 Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803080830.1386442-8-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).