From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@idosch.org>,
Vlad Buslov <vladbu@nvidia.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
netdev@vger.kernel.org,
Wojciech Drewek <wojciech.drewek@intel.com>,
Simon Horman <horms@kernel.org>,
Sujai Buvaneswaran <sujai.buvaneswaran@intel.com>
Subject: Re: [PATCH net-next 2/7] ice: Support untagged VLAN traffic in br offload
Date: Thu, 3 Aug 2023 18:58:52 +0300 [thread overview]
Message-ID: <20230803155852.glz4rqvrhx55ke3m@skbuf> (raw)
In-Reply-To: <20230802193142.59fe5bf3@kernel.org>
On Wed, Aug 02, 2023 at 07:31:42PM -0700, Jakub Kicinski wrote:
> On Tue, 1 Aug 2023 10:31:07 -0700 Tony Nguyen wrote:
> > From: Wojciech Drewek <wojciech.drewek@intel.com>
> >
> > When driver receives SWITCHDEV_FDB_ADD_TO_DEVICE notification
> > with vid = 1, it means that we have to offload untagged traffic.
> > This is achieved by adding vlan metadata lookup.
>
> Paul already asked about this behavior but it's unclear to me from the
> answer whether this is a local custom or legit switchdev behavior.
> Could someone with switchdev knowledge glance over this?
The only special vid is vid=0 (and that implies a VLAN-unaware FDB entry).
vid=1 is not special. Packets match on an FDB entry with vid=1 if they
are classified to VID 1 (obviously). That can happen if the bridge port
is VLAN-aware (bridge vlan_filtering=1) and:
- packet was untagged and pvid of the ingress port was 1, or
- packet was VLAN-tagged and the VID in the packet was 1
If the bridge has vlan_filtering=0, the rules are different, and packets
should only match FDB entries with vid=0. Both the (bridge) pvid of the
port and the VLAN header from the packet are to be ignored.
next prev parent reply other threads:[~2023-08-03 15:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 17:31 [PATCH net-next 0/7][pull request] Intel Wired LAN Driver Updates 2023-08-01 (ice) Tony Nguyen
2023-08-01 17:31 ` [PATCH net-next 1/7] ice: Accept LAG netdevs in bridge offloads Tony Nguyen
2023-08-01 17:31 ` [PATCH net-next 2/7] ice: Support untagged VLAN traffic in br offload Tony Nguyen
2023-08-03 2:31 ` Jakub Kicinski
2023-08-03 15:58 ` Vladimir Oltean [this message]
2023-08-04 9:32 ` Drewek, Wojciech
2023-08-04 18:02 ` Tony Nguyen
2023-08-01 17:31 ` [PATCH net-next 3/7] ice: Add direction metadata Tony Nguyen
2023-08-01 17:31 ` [PATCH net-next 4/7] ice: Rename enum ice_pkt_flags values Tony Nguyen
2023-08-01 17:31 ` [PATCH net-next 5/7] ice: Add get C827 PHY index function Tony Nguyen
2023-08-03 2:28 ` Jakub Kicinski
2023-08-01 17:31 ` [PATCH net-next 6/7] ice: add FW load wait Tony Nguyen
2023-08-01 17:31 ` [PATCH net-next 7/7] ice: clean up __ice_aq_get_set_rss_lut() Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230803155852.glz4rqvrhx55ke3m@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=anthony.l.nguyen@intel.com \
--cc=horms@kernel.org \
--cc=idosch@idosch.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sujai.buvaneswaran@intel.com \
--cc=vladbu@nvidia.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox